feat: support xdebug in tests

Author: xepozz

tests/Acceptance/App/Input/Command.php

@@ -18,12 +18,19 @@ final class Command
     /** @var non-empty-string|null */
     public ?string $tlsCert = null;
 
+    private array $xdebug;
+
     public static function fromEnv(): self
     {
         $self = new self();
 
         $self->namespace = \getenv('TEMPORAL_NAMESPACE') ?: 'default';
         $self->address = \getenv('TEMPORAL_ADDRESS') ?: 'localhost:7233';
+        $self->xdebug = [
+            'xdebug.mode' => \ini_get('xdebug.mode'),
+            'xdebug.start_with_request' => \ini_get('xdebug.start_with_request'),
+            'xdebug.start_upon_error' => \ini_get('xdebug.start_upon_error'),
+        ];
         // $self->tlsCert =
         // $self->tlsKey =
 
@@ -66,7 +73,7 @@ public static function fromCommandLine(array $argv): self
     /**
      * @return list<non-empty-string> CLI arguments that can be parsed by `fromCommandLine`
      */
-    public function toCommandLineArguments(): array
+    public function getCommandLineArguments(): array
     {
         $result = [];
         $this->namespace === null or $result[] = "namespace=$this->namespace";
@@ -76,4 +83,13 @@ public function toCommandLineArguments(): array
 
         return $result;
     }
+
+    public function getPhpBinaryArguments(): array
+    {
+        $result = [];
+        foreach ($this->xdebug as $key => $value) {
+            $result[] = "-d$key=$value";
+        }
+        return $result;
+    }
 }

tests/Acceptance/App/Runtime/RRStarter.php

@@ -39,9 +39,10 @@ public function start(): void
             "temporal.address={$this->runtime->address}",
             '-o',
             'server.command=' . \implode(',', [
-                'php',
+                PHP_BINARY,
+                ...$run->getPhpBinaryArguments(),
                 $this->runtime->rrConfigDir . DIRECTORY_SEPARATOR . 'worker.php',
-                ...$run->toCommandLineArguments(),
+                ...$run->getCommandLineArguments(),
             ]),
         ];
         $run->tlsKey === null or $rrCommand = [...$rrCommand, '-o', "tls.key={$run->tlsKey}"];

tests/Acceptance/bootstrap.php

@@ -27,7 +27,7 @@
 use Temporal\Tests\Acceptance\App\RuntimeBuilder;
 use Temporal\Tests\Acceptance\App\Support;
 
-chdir(__DIR__ . '/../..');
+\chdir(__DIR__ . '/../..');
 require './vendor/autoload.php';
 
 RuntimeBuilder::init();
@@ -91,8 +91,8 @@
 $container->bindSingleton(ScheduleClientInterface::class, $scheduleClient);
 $container->bindInjector(WorkflowStubInterface::class, WorkflowStubInjector::class);
 $container->bindSingleton(DataConverterInterface::class, $converter);
-$container->bind(RPCInterface::class, static fn() => RPC::create(getenv('RR_RPC_ADDRESS') ?: 'tcp://127.0.0.1:6001'));
+$container->bind(RPCInterface::class, static fn() => RPC::create(\getenv('RR_RPC_ADDRESS') ?: 'tcp://127.0.0.1:6001'));
 $container->bind(
     StorageInterface::class,
-    fn(#[Proxy] ContainerInterface $c): StorageInterface => $c->get(Factory::class)->select('harness'),
+    static fn(#[Proxy] ContainerInterface $c): StorageInterface => $c->get(Factory::class)->select('harness'),
 );

tests/Functional/.rr.silent.yaml

@@ -5,8 +5,6 @@ rpc:
 
 server:
     command: "php worker.php"
-    env:
-        XDEBUG_SESSION: 1
 
 # Workflow and activity mesh service
 temporal: