Move new plugin test to bridge

Author: yuandrew

tests/bridge/test_plugins.py

@@ -0,0 +1,39 @@
+from collections import Counter
+
+import pytest
+
+import temporalio.bridge.temporal_sdk_bridge
+from temporalio.client import Client
+from temporalio.plugin import SimplePlugin
+from temporalio.worker import Worker
+from tests.worker.test_worker import never_run_activity
+
+
+async def test_worker_plugin_names_forwarded_to_core(
+    client: Client, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    captured_plugins: list[str] = []
+
+    original_new_worker = temporalio.bridge.temporal_sdk_bridge.new_worker
+
+    def new_worker_wrapper(runtime_ref, client_ref, config):
+        nonlocal captured_plugins
+        captured_plugins = list(config.plugins)
+        return original_new_worker(runtime_ref, client_ref, config)
+
+    monkeypatch.setattr(
+        temporalio.bridge.temporal_sdk_bridge,
+        "new_worker",
+        new_worker_wrapper,
+    )
+
+    plugin1 = SimplePlugin("test-worker-plugin1")
+    plugin2 = SimplePlugin("test-worker-plugin2")
+    Worker(
+        client,
+        task_queue="queue",
+        activities=[never_run_activity],
+        plugins=[plugin1, plugin2],
+    )
+    # Use counter to compare unordered lists
+    assert Counter(captured_plugins) == Counter([plugin1.name(), plugin2.name()])

tests/test_plugins.py

@@ -6,7 +6,6 @@
 
 import pytest
 
-import temporalio.bridge.temporal_sdk_bridge
 import temporalio.client
 import temporalio.converter
 import temporalio.worker
@@ -178,35 +177,6 @@ async def test_worker_plugin_basic_config(client: Client) -> None:
     ]
 
 
-async def test_worker_plugin_names_forwarded_to_core(
-    client: Client, monkeypatch: pytest.MonkeyPatch
-) -> None:
-    captured_plugins: list[str] = []
-
-    original_new_worker = temporalio.bridge.temporal_sdk_bridge.new_worker
-
-    def new_worker_wrapper(runtime_ref, client_ref, config):
-        nonlocal captured_plugins
-        captured_plugins = list(config.plugins)
-        return original_new_worker(runtime_ref, client_ref, config)
-
-    monkeypatch.setattr(
-        temporalio.bridge.temporal_sdk_bridge,
-        "new_worker",
-        new_worker_wrapper,
-    )
-
-    plugin1 = SimplePlugin("test-worker-plugin1")
-    plugin2 = SimplePlugin("test-worker-plugin2")
-    worker = Worker(
-        client,
-        task_queue="queue",
-        activities=[never_run_activity],
-        plugins=[plugin1, plugin2],
-    )
-    assert captured_plugins == [plugin1.name(), plugin2.name()]
-
-
 async def test_worker_duplicated_plugin(client: Client) -> None:
     new_config = client.config()
     new_config["plugins"] = [MyCombinedPlugin()]