Skip to content

Commit 0ad6289

Browse files
committed
Revert "Fix hanging nexus test by cleaning up NonTerminatingWorkflow"
This reverts commit 43b7083.
1 parent 15452b3 commit 0ad6289

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

tests/nexus/test_workflow_caller_errors.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ async def test_nexus_operation_fails_without_retry_as_handler_error(
206206
client,
207207
nexus_service_handlers=[ErrorTestService()],
208208
nexus_task_executor=concurrent.futures.ThreadPoolExecutor(max_workers=1),
209-
workflows=[CallerWorkflow, NonTerminatingWorkflow],
209+
workflows=[CallerWorkflow],
210210
task_queue=input.task_queue,
211211
):
212212
await create_nexus_endpoint(input.task_queue, client)
@@ -227,13 +227,6 @@ async def test_nexus_operation_fails_without_retry_as_handler_error(
227227
assert handler_error_message in str(handler_error)
228228
else:
229229
pytest.fail("Unreachable")
230-
finally:
231-
if operation_name == "fails_due_to_workflow_already_started":
232-
try:
233-
handle = client.get_workflow_handle("second-start-request-will-fail")
234-
await handle.terminate()
235-
except Exception:
236-
pass
237230

238231

239232
# Start timeout test

0 commit comments

Comments
 (0)