Interesting

Author: dandavison

temporalio/contrib/opentelemetry.py

@@ -71,7 +71,7 @@ class should return the workflow interceptor subclass from
     custom attributes desired.
     """
 
-    def __init__(
+    def __init__(  # type: ignore[reportMissingSuperCall]
         self,
         tracer: Optional[opentelemetry.trace.Tracer] = None,
         *,
@@ -125,11 +125,10 @@ def workflow_interceptor_class(
         :py:meth:`temporalio.worker.Interceptor.workflow_interceptor_class`.
         """
         # Set the externs needed
-        # TODO(cretz): MyPy works w/ spread kwargs instead of direct passing
         input.unsafe_extern_functions.update(
-            **_WorkflowExternFunctions(
-                __temporal_opentelemetry_completed_span=self._completed_workflow_span,
-            )
+            {
+                "__temporal_opentelemetry_completed_span": self._completed_workflow_span,
+            }
         )
         return TracingWorkflowInboundInterceptor
 

temporalio/converter.py

@@ -508,7 +508,7 @@ def default(self, o: Any) -> Any:
         if isinstance(o, datetime):
             return o.isoformat()
         # Dataclass support
-        if dataclasses.is_dataclass(o):
+        if dataclasses.is_dataclass(o) and not isinstance(o, type):
             return dataclasses.asdict(o)
         # Support for Pydantic v1's dict method
         dict_fn = getattr(o, "dict", None)

temporalio/worker/_activity.py

@@ -818,13 +818,10 @@ def _execute_sync_activity(
         thread_id = threading.current_thread().ident
         if thread_id is not None:
             cancel_thread_raiser.set_thread_id(thread_id)
-    heartbeat_fn: Callable[..., None]
     if isinstance(heartbeat, SharedHeartbeatSender):
-        # To make mypy happy
-        heartbeat_sender = heartbeat
-        heartbeat_fn = lambda *details: heartbeat_sender.send_heartbeat(
-            info.task_token, *details
-        )
+
+        def heartbeat_fn(*details: Any) -> None:
+            heartbeat.send_heartbeat(info.task_token, *details)
     else:
         heartbeat_fn = heartbeat
     temporalio.activity._Context.set(
@@ -902,7 +899,7 @@ async def register_heartbeater(
         raise NotImplementedError
 
     @abstractmethod
-    def unregister_heartbeater(self, task_token: bytes) -> None:
+    async def unregister_heartbeater(self, task_token: bytes) -> None:
         """Unregisters a previously registered heartbeater for the task
         token. This should also flush any pending heartbeats.
         """