Only set timeouts for default model provider

Author: tconley1428

temporalio/contrib/openai_agents/_temporal_openai_agents.py

@@ -1,6 +1,7 @@
 """Initialize Temporal OpenAI Agents overrides."""
 
 from contextlib import contextmanager
+from datetime import timedelta
 from typing import AsyncIterator, Callable, Optional, Union
 
 from agents import (
@@ -39,7 +40,7 @@
 
 @contextmanager
 def set_open_ai_agent_temporal_overrides(
-    model_params: Optional[ModelActivityParameters] = None,
+    model_params: ModelActivityParameters,
     auto_close_tracing_in_workflows: bool = False,
 ):
     """Configure Temporal-specific overrides for OpenAI agents.
@@ -69,14 +70,6 @@ def set_open_ai_agent_temporal_overrides(
     if model_params is None:
         model_params = ModelActivityParameters()
 
-    if (
-        not model_params.start_to_close_timeout
-        and not model_params.schedule_to_close_timeout
-    ):
-        raise ValueError(
-            "Activity must have start_to_close_timeout or schedule_to_close_timeout"
-        )
-
     previous_runner = get_default_agent_runner()
     previous_trace_provider = get_trace_provider()
     provider = TemporalTraceProvider(
@@ -208,6 +201,22 @@ def __init__(
             model_provider: Optional model provider for custom model implementations.
                 Useful for testing or custom model integrations.
         """
+        if model_params is None:
+            model_params = ModelActivityParameters()
+
+        # For the default provider, we provide a default start_to_close_timeout of 60 seconds.
+        # Other providers will need to define their own.
+        if (
+            model_params.start_to_close_timeout is None
+            and model_params.schedule_to_close_timeout is None
+        ):
+            if model_provider is None:
+                model_params.start_to_close_timeout = timedelta(seconds=60)
+            else:
+                raise ValueError(
+                    "When configuring a custom provider, the model activity must have start_to_close_timeout or schedule_to_close_timeout"
+                )
+
         self._model_params = model_params
         self._model_provider = model_provider
 

tests/contrib/openai_agents/test_openai.py

@@ -1800,7 +1800,7 @@ def status_error(status: int):
             model_params=ModelActivityParameters(
                 retry_policy=RetryPolicy(maximum_attempts=2),
             ),
-            model_provider=TestModelProvider(TestModel(lambda: status_error(status)))
+            model_provider=TestModelProvider(TestModel(lambda: status_error(status))),
         )
     ]
     client = Client(**new_config)

tests/contrib/openai_agents/test_openai_replay.py

@@ -3,6 +3,7 @@
 import pytest
 
 from temporalio.client import WorkflowHistory
+from temporalio.contrib.openai_agents import ModelActivityParameters
 from temporalio.contrib.openai_agents._temporal_openai_agents import (
     set_open_ai_agent_temporal_overrides,
 )
@@ -35,7 +36,7 @@ async def test_replay(file_name: str) -> None:
     with (Path(__file__).with_name("histories") / file_name).open("r") as f:
         history_json = f.read()
 
-        with set_open_ai_agent_temporal_overrides():
+        with set_open_ai_agent_temporal_overrides(ModelActivityParameters()):
             await Replayer(
                 workflows=[
                     ResearchWorkflow,