Cleanup

Author: dandavison

temporalio/client.py

@@ -2852,7 +2852,7 @@ async def report_cancellation(
         )
 
     # TODO(dan): should this return Self (requiring that the user's subclass has the same
-    # constructor signature)?
+    # constructor signature)? CompositePayloadConverter.with_context does.
     def with_context(self, context: SerializationContext) -> AsyncActivityHandle:
         """Create a new AsyncActivityHandle with a different serialization context.
 

temporalio/converter.py

@@ -84,7 +84,8 @@ class SerializationContext(ABC):
       not of the currently executing (i.e. parent) workflow.
     - In workflow code, when operating on a payload to be sent/received to/from an activity, the
       context type is :py:class:`ActivitySerializationContext` and the workflow ID is that of the
-      currently-executing workflow. ActivitySerializationContext is also set on operations
+      currently-executing workflow. ActivitySerializationContext is also set on data converter
+      operations in the activity context.
     """
 
     pass
@@ -438,6 +439,8 @@ def with_context(self, context: SerializationContext) -> Self:
         if not any_with_context:
             return self
 
+        # A user who has created a subclass with a non-nullary constructor must override this
+        # method.
         new_instance = type(self)()
         new_instance._set_converters(*converters)
         return new_instance

temporalio/worker/_workflow_instance.py

@@ -957,7 +957,7 @@ def _apply_resolve_nexus_operation(
             return
 
         # We don't set a serialization context for nexus operations on the caller side because it is
-        # not possible to do so on the handler side.
+        # not possible to set the same context on the handler side.
         payload_converter, failure_converter = (
             self._context_free_payload_converter,
             self._context_free_failure_converter,
@@ -2091,7 +2091,7 @@ def _converters_with_context(
 
         This plays a similar role to DataConverter._with_context, but operates on PayloadConverter
         and FailureConverter only (since payload encoding/decoding is done by the worker, outside
-        the workflowsandbox).
+        the workflow sandbox).
         """
         payload_converter = self._context_free_payload_converter
         failure_converter = self._context_free_failure_converter
@@ -2101,7 +2101,6 @@ def _converters_with_context(
             failure_converter = failure_converter.with_context(context)
         return payload_converter, failure_converter
 
-    # _WorkflowInstanceImpl.get_pending_command_serialization_context
     def get_payload_codec_with_context(
         self,
         payload_codec: temporalio.converter.PayloadCodec,
@@ -2430,8 +2429,6 @@ async def _signal_external_workflow(
         done_fut = self.create_future()
         command.signal_external_workflow_execution.seq = seq
 
-        # Set as pending with the target workflow ID for later context use
-        # Extract the workflow ID from the command
         target_workflow_id = (
             command.signal_external_workflow_execution.child_workflow_id
             or command.signal_external_workflow_execution.workflow_execution.workflow_id