Skip to content

Commit 2ca6a0c

Browse files
committed
Skip tests under Java test server
1 parent 68d7aee commit 2ca6a0c

File tree

1 file changed

+38
-6
lines changed

1 file changed

+38
-6
lines changed

tests/worker/test_update_with_start.py

Lines changed: 38 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
WorkflowIDConflictPolicy,
2525
)
2626
from temporalio.exceptions import ApplicationError, WorkflowAlreadyStartedError
27+
from temporalio.testing import WorkflowEnvironment
2728
from tests.helpers import (
2829
new_worker,
2930
)
@@ -87,8 +88,15 @@ class TestUpdateWithStart:
8788
[WorkflowUpdateStage.ACCEPTED, WorkflowUpdateStage.COMPLETED],
8889
)
8990
async def test_non_blocking_update_with_must_create_workflow_semantics(
90-
self, client: Client, wait_for_stage: WorkflowUpdateStage
91+
self,
92+
client: Client,
93+
env: WorkflowEnvironment,
94+
wait_for_stage: WorkflowUpdateStage,
9195
):
96+
if env.supports_time_skipping:
97+
pytest.skip(
98+
"TODO: make update_with_start_tests pass under Java test server"
99+
)
92100
await self._do_test(
93101
client,
94102
f"test-uws-nb-mc-wf-id-{wait_for_stage.name}",
@@ -103,8 +111,15 @@ async def test_non_blocking_update_with_must_create_workflow_semantics(
103111
[WorkflowUpdateStage.ACCEPTED, WorkflowUpdateStage.COMPLETED],
104112
)
105113
async def test_non_blocking_update_with_get_or_create_workflow_semantics(
106-
self, client: Client, wait_for_stage: WorkflowUpdateStage
114+
self,
115+
client: Client,
116+
env: WorkflowEnvironment,
117+
wait_for_stage: WorkflowUpdateStage,
107118
):
119+
if env.supports_time_skipping:
120+
pytest.skip(
121+
"TODO: make update_with_start_tests pass under Java test server"
122+
)
108123
await self._do_test(
109124
client,
110125
f"test-uws-nb-goc-wf-id-{wait_for_stage.name}",
@@ -119,8 +134,15 @@ async def test_non_blocking_update_with_get_or_create_workflow_semantics(
119134
[WorkflowUpdateStage.ACCEPTED, WorkflowUpdateStage.COMPLETED],
120135
)
121136
async def test_blocking_update_with_get_or_create_workflow_semantics(
122-
self, client: Client, wait_for_stage: WorkflowUpdateStage
137+
self,
138+
client: Client,
139+
env: WorkflowEnvironment,
140+
wait_for_stage: WorkflowUpdateStage,
123141
):
142+
if env.supports_time_skipping:
143+
pytest.skip(
144+
"TODO: make update_with_start_tests pass under Java test server"
145+
)
124146
await self._do_test(
125147
client,
126148
f"test-uws-b-goc-wf-id-{wait_for_stage.name}",
@@ -286,7 +308,11 @@ def assert_network_call(
286308
assert _wrapped_poll.called == expect_network_call
287309

288310

289-
async def test_update_with_start_sets_first_execution_run_id(client: Client):
311+
async def test_update_with_start_sets_first_execution_run_id(
312+
client: Client, env: WorkflowEnvironment
313+
):
314+
if env.supports_time_skipping:
315+
pytest.skip("TODO: make update_with_start_tests pass under Java test server")
290316
async with new_worker(
291317
client,
292318
WorkflowForUpdateWithStartTest,
@@ -360,12 +386,16 @@ def make_start_op(workflow_id: str):
360386
assert (await start_op_4.workflow_handle()).first_execution_run_id is not None
361387

362388

363-
async def test_update_with_start_failure_start_workflow_error(client: Client):
389+
async def test_update_with_start_failure_start_workflow_error(
390+
client: Client, env: WorkflowEnvironment
391+
):
364392
"""
365393
When the workflow start fails, the update_with_start_call should raise the appropriate
366394
gRPC error, and the start_workflow_operation promise should be rejected with the same
367395
error.
368396
"""
397+
if env.supports_time_skipping:
398+
pytest.skip("TODO: make update_with_start_tests pass under Java test server")
369399
async with new_worker(
370400
client,
371401
WorkflowForUpdateWithStartTest,
@@ -439,8 +469,10 @@ async def my_update(self, arg: str) -> str:
439469

440470

441471
async def test_update_with_start_client_outbound_interceptor(
442-
client: Client,
472+
client: Client, env: WorkflowEnvironment
443473
):
474+
if env.supports_time_skipping:
475+
pytest.skip("TODO: make update_with_start_tests pass under Java test server")
444476
interceptor = SimpleClientInterceptor()
445477
client = Client(**{**client.config(), "interceptors": [interceptor]}) # type: ignore
446478

0 commit comments

Comments
 (0)