Linting

Author: tconley1428

temporalio/worker/_workflow_instance.py

@@ -145,6 +145,7 @@ class WorkflowInstanceDetails:
     worker_level_failure_exception_types: Sequence[Type[BaseException]]
     last_completion_result: temporalio.api.common.v1.Payloads
 
+
 class WorkflowInstance(ABC):
     """Instance of a workflow that can handle activations."""
 
@@ -1688,14 +1689,25 @@ def workflow_set_current_details(self, details: str):
         self._assert_not_read_only("set current details")
         self._current_details = details
 
-    def workflow_last_completion_result(self, type_hint: Optional[Type]) -> Optional[Any]:
+    def workflow_last_completion_result(
+        self, type_hint: Optional[Type]
+    ) -> Optional[Any]:
         if len(self._last_completion_result.payloads) == 0:
             return None
         elif len(self._last_completion_result.payloads) > 1:
-            warnings.warn(f"Expected single last completion result, got {len(self._last_completion_result.payloads)}")
+            warnings.warn(
+                f"Expected single last completion result, got {len(self._last_completion_result.payloads)}"
+            )
             return None
 
-        return self._payload_converter.from_payload(self._last_completion_result.payloads[0], type_hint)
+        if type_hint is None:
+            return self._payload_converter.from_payload(
+                self._last_completion_result.payloads[0]
+            )
+        else:
+            return self._payload_converter.from_payload(
+                self._last_completion_result.payloads[0], type_hint
+            )
 
     #### Calls from outbound impl ####
     # These are in alphabetical order and all start with "_outbound_".

temporalio/worker/workflow_sandbox/_runner.py

@@ -18,6 +18,8 @@
 import temporalio.worker._workflow_instance
 import temporalio.workflow
 
+from ...api.common.v1.message_pb2 import Payloads
+
 # Workflow instance has to be relative import
 from .._workflow_instance import (
     UnsandboxedWorkflowRunner,
@@ -27,7 +29,6 @@
 )
 from ._importer import Importer
 from ._restrictions import RestrictionContext, SandboxRestrictions
-from ...api.common.v1.message_pb2 import Payloads
 
 _fake_info = temporalio.workflow.Info(
     attempt=-1,

temporalio/workflow.py

@@ -898,7 +898,9 @@ def workflow_get_current_details(self) -> str: ...
     def workflow_set_current_details(self, details: str): ...
 
     @abstractmethod
-    def workflow_last_completion_result(self, type_hint: Optional[Type]) -> Optional[Any]: ...
+    def workflow_last_completion_result(
+        self, type_hint: Optional[Type]
+    ) -> Optional[Any]: ...
 
 
 _current_update_info: contextvars.ContextVar[UpdateInfo] = contextvars.ContextVar(
@@ -1042,6 +1044,10 @@ def get_current_details() -> str:
     return _Runtime.current().workflow_get_current_details()
 
 
+@overload
+def get_last_completion_result() -> Optional[Any]: ...
+
+
 @overload
 def get_last_completion_result(type_hint: Type[ParamType]) -> Optional[ParamType]: ...
 

tests/test_client.py

@@ -4,7 +4,7 @@
 import os
 import uuid
 from datetime import datetime, timedelta, timezone
-from typing import Any, List, Mapping, Optional, cast, Tuple
+from typing import Any, List, Mapping, Optional, Tuple, cast
 from unittest import mock
 
 import google.protobuf.any_pb2
@@ -92,9 +92,10 @@
 from temporalio.testing import WorkflowEnvironment
 from tests.helpers import (
     assert_eq_eventually,
+    assert_eventually,
     ensure_search_attributes_present,
     new_worker,
-    worker_versioning_enabled, assert_eventually,
+    worker_versioning_enabled,
 )
 from tests.helpers.worker import (
     ExternalWorker,
@@ -1534,20 +1535,26 @@ async def test_schedule_last_completion_result(
             ),
         )
         await handle.trigger()
+
         async def get_schedule_result() -> Tuple[int, Optional[str]]:
             desc = await handle.describe()
             length = len(desc.info.recent_actions)
             if length == 0:
                 return length, None
             else:
-                workflow_id = cast(ScheduleActionExecutionStartWorkflow, desc.info.recent_actions[-1].action).workflow_id
+                workflow_id = cast(
+                    ScheduleActionExecutionStartWorkflow,
+                    desc.info.recent_actions[-1].action,
+                ).workflow_id
                 workflow_handle = client.get_workflow_handle(workflow_id)
                 result = await workflow_handle.result()
                 return length, result
 
         assert await get_schedule_result() == (1, "My First Result")
         await handle.trigger()
-        assert await get_schedule_result() == (2, "From last completion: My First Result")
+        assert await get_schedule_result() == (
+            2,
+            "From last completion: My First Result",
+        )
 
         await handle.delete()
-