fallback address to localhost default

Author: THardy98

temporalio/envconfig.py

@@ -6,7 +6,7 @@
 
 from __future__ import annotations
 
-from dataclasses import dataclass, field
+from dataclasses import dataclass, field, replace
 from pathlib import Path
 from typing import Any, Dict, Literal, Mapping, Optional, Union, cast
 
@@ -253,7 +253,7 @@ def to_client_connect_config(self) -> ClientConnectConfig:
 
     @staticmethod
     def load(
-        profile: str = "default",
+        profile: Optional[str] = None,
         *,
         config_source: Optional[DataSource] = None,
         disable_file: bool = False,
@@ -268,7 +268,8 @@ def load(
         :py:meth:`to_client_connect_config` method on the returned profile.
 
         Args:
-            profile: Profile to load from the config.
+            profile: Profile to load from the config. If the profile is provided,
+                the default profile is returned.
             config_source: If present, this is used as the configuration source
                 instead of default file locations. This can be a path to the file
                 or the string/byte contents of the file.
@@ -298,7 +299,13 @@ def load(
             config_file_strict=config_file_strict,
             env_vars=override_env_vars,
         )
-        return ClientConfigProfile.from_dict(raw_profile)
+        prof = ClientConfigProfile.from_dict(raw_profile)
+
+        # If no address is present, default to localhost
+        if prof.address is None:
+            prof = replace(prof, address="localhost:7233")
+
+        return prof
 
 
 @dataclass
@@ -377,7 +384,7 @@ def load(
 
     @staticmethod
     def load_client_connect_config(
-        profile: str = "default",
+        profile: Optional[str] = None,
         *,
         config_file: Optional[str] = None,
         disable_file: bool = False,
@@ -392,7 +399,8 @@ def load_client_connect_config(
         process's environment for overrides unless disabled.
 
         Args:
-            profile: The profile to load from the config. Defaults to "default".
+            profile: Profile to load from the config. If the profile is provided,
+                the default profile is returned.
             config_file: Path to a specific TOML config file. If not provided,
                 default file locations are used. This is ignored if
                 ``disable_file`` is true.

tests/test_envconfig.py

@@ -308,6 +308,20 @@ def test_load_profile_strict_mode_fail(tmp_path: Path):
         ClientConfigProfile.load(config_source=config_file, config_file_strict=True)
 
 
+def test_load_profile_default_missing_is_ok():
+    """Confirm that loading with no profile from a config without 'default' is ok."""
+    profile = ClientConfigProfile.load(config_source=TOML_CONFIG_TLS_DETAILED)
+    # Should be a profile with the default address
+    assert profile.address == "localhost:7233"
+    assert profile.namespace is None
+    # But if we ask for the 'default' profile, it should fail since it's not
+    # in the config
+    with pytest.raises(RuntimeError, match="Profile 'default' not found"):
+        ClientConfigProfile.load(
+            config_source=TOML_CONFIG_TLS_DETAILED, profile="default"
+        )
+
+
 def test_load_profiles_from_data_malformed():
     """Test that loading malformed TOML data raises an error."""
     with pytest.raises(RuntimeError, match="TOML parse error"):