Skip to content

Commit 4d355d1

Browse files
committed
Revert "TEMP: Alter manual activity tests to not require worker"
This reverts commit 7127c0fe5296d6df4c174f2792447c98934a95ce.
1 parent 269d532 commit 4d355d1

File tree

1 file changed

+18
-29
lines changed

1 file changed

+18
-29
lines changed

tests/test_activity.py

Lines changed: 18 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@
1111
from temporalio.exceptions import ApplicationError, CancelledError
1212
from temporalio.worker import Worker
1313

14-
STANDALONE_ACTIVITY_MATCHING_TASKS_IMPLEMENTED = False
15-
16-
pytest.skip("Standalone activity is not implemented in server", allow_module_level=True)
17-
1814

1915
@activity.defn
2016
async def increment(input: int) -> int:
@@ -106,13 +102,12 @@ async def test_manual_completion(client: Client):
106102
activities=[async_activity],
107103
workflows=[WaitForSignalWorkflow],
108104
):
109-
if STANDALONE_ACTIVITY_MATCHING_TASKS_IMPLEMENTED:
110-
# Wait for activity to start
111-
await client.execute_workflow(
112-
WaitForSignalWorkflow.run,
113-
id=wait_for_signal_workflow_id,
114-
task_queue=task_queue,
115-
)
105+
# Wait for activity to start
106+
await client.execute_workflow(
107+
WaitForSignalWorkflow.run,
108+
id=wait_for_signal_workflow_id,
109+
task_queue=task_queue,
110+
)
116111
# Complete activity manually
117112
async_activity_handle = client.get_async_activity_handle(
118113
activity_id=activity_id,
@@ -143,14 +138,11 @@ async def test_manual_cancellation(client: Client):
143138
activities=[async_activity],
144139
workflows=[WaitForSignalWorkflow],
145140
):
146-
if STANDALONE_ACTIVITY_MATCHING_TASKS_IMPLEMENTED:
147-
# Wait for activity to start
148-
await client.execute_workflow(
149-
WaitForSignalWorkflow.run,
150-
id=wait_for_signal_workflow_id,
151-
task_queue=task_queue,
152-
)
153-
# Cancel activity manually
141+
await client.execute_workflow(
142+
WaitForSignalWorkflow.run,
143+
id=wait_for_signal_workflow_id,
144+
task_queue=task_queue,
145+
)
154146
async_activity_handle = client.get_async_activity_handle(
155147
activity_id=activity_id,
156148
run_id=activity_handle.run_id,
@@ -182,14 +174,11 @@ async def test_manual_fail(client: Client):
182174
activities=[async_activity],
183175
workflows=[WaitForSignalWorkflow],
184176
):
185-
if STANDALONE_ACTIVITY_MATCHING_TASKS_IMPLEMENTED:
186-
# Wait for activity to start
187-
await client.execute_workflow(
188-
WaitForSignalWorkflow.run,
189-
id=wait_for_signal_workflow_id,
190-
task_queue=task_queue,
191-
)
192-
# Fail activity manually
177+
await client.execute_workflow(
178+
WaitForSignalWorkflow.run,
179+
id=wait_for_signal_workflow_id,
180+
task_queue=task_queue,
181+
)
193182
async_activity_handle = client.get_async_activity_handle(
194183
activity_id=activity_id,
195184
run_id=activity_handle.run_id,
@@ -241,13 +230,13 @@ async def test_manual_heartbeat(client: Client):
241230
activities=[activity_for_testing_heartbeat],
242231
workflows=[WaitForSignalWorkflow],
243232
):
244-
# Send heartbeat manually
245233
async_activity_handle = client.get_async_activity_handle(
246234
activity_id=activity_id,
247235
run_id=activity_handle.run_id,
248236
)
249237
await async_activity_handle.heartbeat("Test heartbeat details")
250-
await client.get_workflow_handle(
238+
await client.get_workflow_handle_for(
239+
WaitForSignalWorkflow.run,
251240
workflow_id=wait_for_signal_workflow_id,
252241
).signal(WaitForSignalWorkflow.signal)
253242
assert await activity_handle.result() == "Test heartbeat details"

0 commit comments

Comments
 (0)