Skip to content

Commit 50cbd42

Browse files
committed
Revert "Add some logs to help debug test flaking with timeouts"
This reverts commit c053aa6.
1 parent db3bb0e commit 50cbd42

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

tests/contrib/test_opentelemetry.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -588,28 +588,21 @@ async def test_opentelemetry_safe_detach(client: Client):
588588

589589
with LogCapturer().logs_captured(opentelemetry.context.logger) as capturer:
590590
try:
591-
print("===== in detach test")
592591
handle = await client.start_workflow(
593592
CacheEvictionTearDownWorkflow.run,
594593
id=f"wf-{uuid.uuid4()}",
595594
task_queue=worker.task_queue,
596595
)
597596

598597
# CacheEvictionTearDownWorkflow requires 3 signals to be sent
599-
print("===== signal 1")
600598
await handle.signal(CacheEvictionTearDownWorkflow.signal)
601-
print("===== signal 2")
602599
await handle.signal(CacheEvictionTearDownWorkflow.signal)
603-
print("===== signal 3")
604600
await handle.signal(CacheEvictionTearDownWorkflow.signal)
605601

606-
print("===== awaiting result")
607602
await handle.result()
608603
finally:
609604
sys.unraisablehook = old_hook
610605

611-
print("===== inspecting logs")
612-
613606
# Confirm at least 1 exception
614607
if len(hook_calls) < 1:
615608
logging.warning(
@@ -622,6 +615,6 @@ def otel_context_error(record: logging.LogRecord) -> bool:
622615
and "Failed to detach context" in record.message
623616
)
624617

625-
assert capturer.find(otel_context_error) is None, (
626-
"Detach from context message should not be logged"
627-
)
618+
assert (
619+
capturer.find(otel_context_error) is None
620+
), "Detach from context message should not be logged"

tests/helpers/cache_eviction.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,23 +46,17 @@ async def run(self) -> None:
4646
# Let's also start something in the background that we never wait on
4747
asyncio.create_task(asyncio.sleep(1000))
4848
try:
49-
print("----- in evict workflow")
5049
# Wait for signal count to reach 2
5150
await asyncio.sleep(0.01)
52-
print("----- waiting for signal")
5351
await workflow.wait_condition(lambda: self._signal_count > 1)
5452
finally:
5553
# This finally, on eviction, is actually called but the command
5654
# should be ignored
57-
print("----- sleeping")
5855
await asyncio.sleep(0.01)
59-
print("----- waiting for signals 2 & 3")
6056
await workflow.wait_condition(lambda: self._signal_count > 2)
6157
# Cancel gather tasks and wait on them, but ignore the errors
6258
for task in tasks:
6359
task.cancel()
64-
65-
print("----- evict workflow ending")
6660
await gather_fut
6761

6862
@workflow.signal

0 commit comments

Comments
 (0)