Skip MultiOp statuses with RPCStatusCode.OK

dandavison · dandavison · commit 51a6dec05c6b · 2024-12-18T16:53:35.000-05:00
diff --git a/temporalio/client.py b/temporalio/client.py
@@ -6075,15 +6075,13 @@ def on_start(
                                 and not st.details[0].Is(
                                     temporalio.api.failure.v1.MultiOperationExecutionAborted.DESCRIPTOR
                                 )
+                                and st.code != RPCStatusCode.OK
                             )
                         ),
                         None,
                     )
                     if status and status.code in RPCStatusCode:
-                        if (
-                            status.code == RPCStatusCode.ALREADY_EXISTS
-                            and status.details
-                        ):
+                        if status.code == RPCStatusCode.ALREADY_EXISTS:
                             details = temporalio.api.errordetails.v1.WorkflowExecutionAlreadyStartedFailure()
                             if status.details[0].Unpack(details):
                                 err = temporalio.exceptions.WorkflowAlreadyStartedError(

Original file line number	Diff line number	Diff line change
`@@ -6075,15 +6075,13 @@ def on_start(`
`6075`	`6075`	`and not st.details[0].Is(`
`6076`	`6076`	`temporalio.api.failure.v1.MultiOperationExecutionAborted.DESCRIPTOR`
`6077`	`6077`	`)`
	`6078`	`+ and st.code != RPCStatusCode.OK`
`6078`	`6079`	`)`
`6079`	`6080`	`),`
`6080`	`6081`	`None,`
`6081`	`6082`	`)`
`6082`	`6083`	`if status and status.code in RPCStatusCode:`
`6083`		`- if (`
`6084`		`- status.code == RPCStatusCode.ALREADY_EXISTS`
`6085`		`- and status.details`
`6086`		`- ):`
	`6084`	`+ if status.code == RPCStatusCode.ALREADY_EXISTS:`
`6087`	`6085`	`details = temporalio.api.errordetails.v1.WorkflowExecutionAlreadyStartedFailure()`
`6088`	`6086`	`if status.details[0].Unpack(details):`
`6089`	`6087`	`err = temporalio.exceptions.WorkflowAlreadyStartedError(`