Skip to content

Commit 54d14a7

Browse files
committed
Revert "Reapply "Extend to Tuners""
This reverts commit 73434b5.
1 parent 6ec744f commit 54d14a7

File tree

1 file changed

+0
-74
lines changed

1 file changed

+0
-74
lines changed

tests/nexus/test_worker.py

Lines changed: 0 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,12 @@
33
import asyncio
44
import uuid
55
from datetime import timedelta
6-
from typing import Optional
76

87
import nexusrpc.handler
98
import pytest
109

1110
from temporalio import workflow
1211
from temporalio.client import Client
13-
from temporalio.worker import FixedSizeSlotSupplier, WorkerTuner
1412
from tests.helpers import new_worker
1513
from tests.helpers.nexus import create_nexus_endpoint, make_nexus_endpoint_name
1614

@@ -43,77 +41,6 @@ async def test_max_concurrent_nexus_tasks(
4341
num_nexus_operations: int,
4442
expected_num_executed: int,
4543
):
46-
"""Test max_concurrent_nexus_tasks parameter."""
47-
await _test_nexus_concurrency_helper(
48-
client=client,
49-
num_nexus_operations=num_nexus_operations,
50-
expected_num_executed=expected_num_executed,
51-
max_concurrent_nexus_tasks=max_concurrent_nexus_tasks,
52-
)
53-
54-
55-
@pytest.mark.parametrize(
56-
["num_nexus_operations", "nexus_slots", "expected_num_executed"],
57-
[(1, 1, 1), (2, 1, 1), (43, 42, 42), (43, 44, 43)],
58-
)
59-
async def test_max_concurrent_nexus_tasks_with_tuner(
60-
client: Client,
61-
nexus_slots: int,
62-
num_nexus_operations: int,
63-
expected_num_executed: int,
64-
):
65-
"""Test nexus concurrency using a WorkerTuner."""
66-
tuner = WorkerTuner.create_fixed(
67-
workflow_slots=10,
68-
activity_slots=10,
69-
local_activity_slots=10,
70-
nexus_slots=nexus_slots,
71-
)
72-
await _test_nexus_concurrency_helper(
73-
client=client,
74-
num_nexus_operations=num_nexus_operations,
75-
expected_num_executed=expected_num_executed,
76-
tuner=tuner,
77-
)
78-
79-
80-
@pytest.mark.parametrize(
81-
["num_nexus_operations", "nexus_supplier", "expected_num_executed"],
82-
[
83-
(1, FixedSizeSlotSupplier(1), 1),
84-
(2, FixedSizeSlotSupplier(1), 1),
85-
(43, FixedSizeSlotSupplier(42), 42),
86-
],
87-
)
88-
async def test_max_concurrent_nexus_tasks_with_composite_tuner(
89-
client: Client,
90-
nexus_supplier: FixedSizeSlotSupplier,
91-
num_nexus_operations: int,
92-
expected_num_executed: int,
93-
):
94-
"""Test nexus concurrency using a composite WorkerTuner with nexus_supplier."""
95-
tuner = WorkerTuner.create_composite(
96-
workflow_supplier=FixedSizeSlotSupplier(10),
97-
activity_supplier=FixedSizeSlotSupplier(10),
98-
local_activity_supplier=FixedSizeSlotSupplier(10),
99-
nexus_supplier=nexus_supplier,
100-
)
101-
await _test_nexus_concurrency_helper(
102-
client=client,
103-
num_nexus_operations=num_nexus_operations,
104-
expected_num_executed=expected_num_executed,
105-
tuner=tuner,
106-
)
107-
108-
109-
async def _test_nexus_concurrency_helper(
110-
client: Client,
111-
num_nexus_operations: int,
112-
expected_num_executed: int,
113-
max_concurrent_nexus_tasks: Optional[int] = None,
114-
tuner: Optional[WorkerTuner] = None,
115-
):
116-
assert (max_concurrent_nexus_tasks is None) != (tuner is None)
11744
ids = []
11845
event = asyncio.Event()
11946

@@ -131,7 +58,6 @@ async def op(
13158
NexusCallerWorkflow,
13259
nexus_service_handlers=[MaxConcurrentTestService()],
13360
max_concurrent_nexus_tasks=max_concurrent_nexus_tasks,
134-
tuner=tuner,
13561
) as worker:
13662
await create_nexus_endpoint(worker.task_queue, client)
13763

0 commit comments

Comments
 (0)