Cleanup

Author: dandavison

tests/test_serialization_context.py

@@ -287,21 +287,15 @@ async def activity_with_heartbeat_details() -> TraceData:
     """Activity that checks heartbeat details are decoded with proper context."""
     info = activity.info()
 
-    # If we have heartbeat details, it means we're resuming from a previous attempt
     if info.heartbeat_details:
-        # The heartbeat details should be a TraceData that was decoded with activity context
         assert len(info.heartbeat_details) == 1
         heartbeat_data = info.heartbeat_details[0]
         assert isinstance(heartbeat_data, TraceData)
-        # Return the heartbeat data which should contain the decode trace
         return heartbeat_data
 
-    # First attempt - heartbeat and then fail
     data = TraceData()
     activity.heartbeat(data)
-    # Wait a bit to ensure heartbeat is recorded
     await asyncio.sleep(0.1)
-    # Fail to trigger retry with heartbeat details
     raise Exception("Intentional failure to test heartbeat details")
 
 
@@ -356,9 +350,6 @@ async def test_heartbeat_details_payload_conversion(client: Client):
             )
         )
 
-        # The result should contain the heartbeat data that was decoded with activity context
-        # We expect to see the from_payload trace item for the heartbeat details
-        # This test will FAIL until the bug is fixed
         found_heartbeat_decode = False
         for item in result.items:
             if item.method == "from_payload" and item.context == activity_context:
@@ -796,11 +787,9 @@ def __init__(self) -> None:
     @workflow.run
     async def run(self) -> TraceData:
         try:
-            # Wait for signal
             await workflow.wait_condition(lambda: self.signal_received is not None)
             return self.signal_received or TraceData()
         except asyncio.CancelledError:
-            # Return empty data on cancellation
             return TraceData()
 
     @workflow.signal
@@ -812,7 +801,6 @@ async def external_signal(self, data: TraceData) -> None:
 class ExternalWorkflowSignaler:
     @workflow.run
     async def run(self, target_id: str, data: TraceData) -> TraceData:
-        # Signal external workflow
         handle = workflow.get_external_workflow_handle(target_id)
         await handle.signal(ExternalWorkflowTarget.external_signal, data)
         return data
@@ -822,7 +810,6 @@ async def run(self, target_id: str, data: TraceData) -> TraceData:
 class ExternalWorkflowCanceller:
     @workflow.run
     async def run(self, target_id: str) -> TraceData:
-        # Cancel external workflow
         handle = workflow.get_external_workflow_handle(target_id)
         await handle.cancel()
         return TraceData()
@@ -854,7 +841,6 @@ async def test_external_workflow_signal_and_cancel_payload_conversion(
         activities=[],
         workflow_runner=UnsandboxedWorkflowRunner(),  # so that we can use isinstance
     ):
-        # Test external signal
         target_handle = await client.start_workflow(
             ExternalWorkflowTarget.run,
             id=target_workflow_id,
@@ -868,11 +854,9 @@ async def test_external_workflow_signal_and_cancel_payload_conversion(
             task_queue=task_queue,
         )
 
-        # Wait for both to complete
         signaler_result = await signaler_handle.result()
         await target_handle.result()
 
-        # Verify signal trace
         signaler_context = dataclasses.asdict(
             WorkflowSerializationContext(
                 namespace="default",
@@ -886,8 +870,6 @@ async def test_external_workflow_signal_and_cancel_payload_conversion(
             )
         )
 
-        # This test verifies that external signals SHOULD use the target workflow's context
-        # This is the DESIRED behavior to match .NET
         assert (
             signaler_result.items
             == [
@@ -914,9 +896,6 @@ async def test_external_workflow_signal_and_cancel_payload_conversion(
             ]
         )
 
-        # Note: External cancel doesn't send payloads, so we don't test it here
-        # The cancel context would only be used for failure deserialization
-
 
 # Failure conversion