Fix bugs in upsert search attribs (#440)

Fixed some bugs in search attrib upsert that occur if the workflow has no initial search attribs

Author: Sushisource

temporalio/worker/_workflow_instance.py

@@ -1243,7 +1243,7 @@ def workflow_upsert_search_attributes(
                 # To apply to typed search attributes we remove, replace, or add. We
                 # don't know any of the key types, so we do our best.
                 index = next(
-                    i for i, a in enumerate(mut_typed_attrs) if a.key.name == k
+                    (i for i, a in enumerate(mut_typed_attrs) if a.key.name == k), None
                 )
                 if not vals:
                     if index is not None:
@@ -1285,9 +1285,12 @@ def workflow_upsert_search_attributes(
 
                 # Update typed and untyped in info
                 index = next(
-                    i
-                    for i, a in enumerate(mut_typed_attrs)
-                    if a.key.name == update.key.name
+                    (
+                        i
+                        for i, a in enumerate(mut_typed_attrs)
+                        if a.key.name == update.key.name
+                    ),
+                    None,
                 )
                 if update.value is None:
                     # Delete
@@ -1301,7 +1304,7 @@ def workflow_upsert_search_attributes(
                         update.key, update.value
                     )
                     if index is None:
-                        mut_typed_attrs.append()
+                        mut_typed_attrs.append(pair)
                     else:
                         mut_typed_attrs[index] = pair
                     # Single-item list if not already a sequence for untyped

tests/worker/test_workflow.py

@@ -1824,6 +1824,35 @@ async def describe_attributes_typed(
         assert updated_attrs_typed == await describe_attributes_typed(handle)
 
 
+@workflow.defn
+class NoSearchAttributesWorkflow:
+    @workflow.run
+    async def run(self) -> None:
+        workflow.upsert_search_attributes(
+            [
+                SearchAttributeWorkflow.text_attribute.value_set("text2"),
+            ]
+        )
+        # All we need to do is complete
+
+
+async def test_workflow_no_initial_search_attributes(client: Client, env_type: str):
+    if env_type != "local":
+        pytest.skip("Only testing search attributes on local which disables cache")
+    await ensure_search_attributes_present(
+        client,
+        SearchAttributeWorkflow.text_attribute,
+    )
+    async with new_worker(client, NoSearchAttributesWorkflow) as worker:
+        handle = await client.start_workflow(
+            NoSearchAttributesWorkflow.run,
+            id=f"workflow-{uuid.uuid4()}",
+            task_queue=worker.task_queue,
+            # importantly, no initial search attributes
+        )
+        await handle.result()
+
+
 @workflow.defn
 class LoggingWorkflow:
     def __init__(self) -> None: