PR feedback

Author: tconley1428

temporalio/worker/_workflow.py

@@ -552,9 +552,9 @@ def _create_workflow_instance(
             priority=temporalio.common.Priority._from_proto(init.priority),
         )
 
-        previous_run_failure = None
-        if init.HasField("continued_failure"):
-            previous_run_failure = init.continued_failure
+        last_failure = (
+            init.continued_failure if init.HasField("continued_failure") else None
+        )
 
         # Create instance from details
         det = WorkflowInstanceDetails(
@@ -568,7 +568,7 @@ def _create_workflow_instance(
             disable_eager_activity_execution=self._disable_eager_activity_execution,
             worker_level_failure_exception_types=self._workflow_failure_exception_types,
             last_completion_result=init.last_completion_result,
-            previous_run_failure=previous_run_failure,
+            last_failure=last_failure,
         )
         if defn.sandboxed:
             return self._workflow_runner.create_instance(det)

temporalio/worker/_workflow_instance.py

@@ -145,7 +145,7 @@ class WorkflowInstanceDetails:
     disable_eager_activity_execution: bool
     worker_level_failure_exception_types: Sequence[Type[BaseException]]
     last_completion_result: temporalio.api.common.v1.Payloads
-    previous_run_failure: Optional[Failure]
+    last_failure: Optional[Failure]
 
 
 class WorkflowInstance(ABC):
@@ -324,7 +324,7 @@ def __init__(self, det: WorkflowInstanceDetails) -> None:
         self._current_details = ""
 
         self._last_completion_result = det.last_completion_result
-        self._previous_run_failure = det.previous_run_failure
+        self._last_failure = det.last_failure
 
         # The versioning behavior of this workflow, as established by annotation or by the dynamic
         # config function. Is only set once upon initialization.
@@ -1733,9 +1733,9 @@ def workflow_last_completion_result(
             )
 
     def workflow_last_failure(self) -> Optional[BaseException]:
-        if self._previous_run_failure:
+        if self._last_failure:
             return self._failure_converter.from_failure(
-                self._previous_run_failure, self._payload_converter
+                self._last_failure, self._payload_converter
             )
 
         return None

temporalio/worker/workflow_sandbox/_runner.py

@@ -88,7 +88,7 @@ def prepare_workflow(self, defn: temporalio.workflow._Definition) -> None:
                 disable_eager_activity_execution=False,
                 worker_level_failure_exception_types=self._worker_level_failure_exception_types,
                 last_completion_result=Payloads(),
-                previous_run_failure=Failure(),
+                last_failure=Failure(),
             ),
         )
 

temporalio/workflow.py

@@ -1064,9 +1064,7 @@ def get_current_details() -> str:
 
 
 def has_last_completion_result() -> bool:
-    """Get the last completion result of the workflow. This be None if there was
-    no previous completion or the result was None
-    """
+    """Gets whether there is a last completion result of the workflow."""
     return _Runtime.current().workflow_has_last_completion_result()
 
 
@@ -1079,15 +1077,15 @@ def get_last_completion_result(type_hint: Type[ParamType]) -> Optional[ParamType
 
 
 def get_last_completion_result(type_hint: Optional[Type] = None) -> Optional[Any]:
-    """Get the last completion result of the workflow. This be None if there was
+    """Get the result of the last run of the workflow. This will be None if there was
     no previous completion or the result was None. has_last_completion_result()
     can be used to differentiate.
     """
     return _Runtime.current().workflow_last_completion_result(type_hint)
 
 
 def get_last_failure() -> Optional[BaseException]:
-    """Get the last failure of the workflow."""
+    """Get the last failure of the workflow if it has run previously."""
     return _Runtime.current().workflow_last_failure()