Skip to content

Commit 7605619

Browse files
authored
Rename mcp_servers to mcp_server_providers (#1110)
1 parent 8c4e2c8 commit 7605619

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

temporalio/contrib/openai_agents/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,7 @@ from temporalio.contrib.openai_agents import (
383383
)
384384
from temporalio.worker import Worker
385385

386+
386387
async def main():
387388
# Create the MCP server provider
388389
filesystem_server = StatelessMCPServerProvider(
@@ -403,7 +404,7 @@ async def main():
403404
model_params=ModelActivityParameters(
404405
start_to_close_timeout=timedelta(seconds=60)
405406
),
406-
mcp_servers=[filesystem_server],
407+
mcp_server_providers=[filesystem_server],
407408
),
408409
],
409410
)
@@ -415,6 +416,7 @@ async def main():
415416
)
416417
await worker.run()
417418

419+
418420
if __name__ == "__main__":
419421
asyncio.run(main())
420422
```

temporalio/contrib/openai_agents/_temporal_openai_agents.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ class OpenAIAgentsPlugin(temporalio.client.Plugin, temporalio.worker.Plugin):
196196
of model calls. If None, default parameters will be used.
197197
model_provider: Optional model provider for custom model implementations.
198198
Useful for testing or custom model integrations.
199-
mcp_servers: Sequence of MCP servers to automatically register with the worker.
199+
mcp_server_providers: Sequence of MCP servers to automatically register with the worker.
200200
The plugin will wrap each server in a TemporalMCPServer if needed and
201201
manage their connection lifecycles tied to the worker lifetime. This is
202202
the recommended way to use MCP servers with Temporal workflows.
@@ -223,7 +223,7 @@ class OpenAIAgentsPlugin(temporalio.client.Plugin, temporalio.worker.Plugin):
223223
>>> # Create plugin with MCP servers
224224
>>> plugin = OpenAIAgentsPlugin(
225225
... model_params=model_params,
226-
... mcp_servers=[filesystem_server]
226+
... mcp_server_providers=[filesystem_server]
227227
... )
228228
>>>
229229
>>> # Use with client and worker
@@ -242,7 +242,7 @@ def __init__(
242242
self,
243243
model_params: Optional[ModelActivityParameters] = None,
244244
model_provider: Optional[ModelProvider] = None,
245-
mcp_servers: Sequence[
245+
mcp_server_providers: Sequence[
246246
Union["StatelessMCPServerProvider", "StatefulMCPServerProvider"]
247247
] = (),
248248
) -> None:
@@ -253,7 +253,7 @@ def __init__(
253253
of model calls. If None, default parameters will be used.
254254
model_provider: Optional model provider for custom model implementations.
255255
Useful for testing or custom model integrations.
256-
mcp_servers: Sequence of MCP servers to automatically register with the worker.
256+
mcp_server_providers: Sequence of MCP servers to automatically register with the worker.
257257
Each server will be wrapped in a TemporalMCPServer if not already wrapped,
258258
and their activities will be automatically registered with the worker.
259259
The plugin manages the connection lifecycle of these servers.
@@ -276,7 +276,7 @@ def __init__(
276276

277277
self._model_params = model_params
278278
self._model_provider = model_provider
279-
self._mcp_servers = mcp_servers
279+
self._mcp_server_providers = mcp_server_providers
280280

281281
def init_client_plugin(self, next: temporalio.client.Plugin) -> None:
282282
"""Set the next client plugin"""
@@ -340,13 +340,13 @@ def configure_worker(self, config: WorkerConfig) -> WorkerConfig:
340340
]
341341
new_activities = [ModelActivity(self._model_provider).invoke_model_activity]
342342

343-
server_names = [server.name for server in self._mcp_servers]
343+
server_names = [server.name for server in self._mcp_server_providers]
344344
if len(server_names) != len(set(server_names)):
345345
raise ValueError(
346346
f"More than one mcp server registered with the same name. Please provide unique names."
347347
)
348348

349-
for mcp_server in self._mcp_servers:
349+
for mcp_server in self._mcp_server_providers:
350350
new_activities.extend(mcp_server._get_activities())
351351
config["activities"] = list(config.get("activities") or []) + new_activities
352352

tests/contrib/openai_agents/test_openai.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2438,7 +2438,7 @@ async def get_prompt(
24382438
model_provider=TestModelProvider(TrackingMCPModel())
24392439
if use_local_model
24402440
else None,
2441-
mcp_servers=[server],
2441+
mcp_server_providers=[server],
24422442
)
24432443
]
24442444
client = Client(**new_config)
@@ -2548,7 +2548,7 @@ def override_get_activities() -> Sequence[Callable]:
25482548
start_to_close_timeout=timedelta(seconds=120)
25492549
),
25502550
model_provider=TestModelProvider(TrackingMCPModel()),
2551-
mcp_servers=[server],
2551+
mcp_server_providers=[server],
25522552
)
25532553
]
25542554
client = Client(**new_config)

0 commit comments

Comments
 (0)