remove simple test in favor of a more thorough check for 'unknown rpc call'

Author: VegetarianOrc

tests/test_client.py

@@ -1,4 +1,3 @@
-import asyncio
 import dataclasses
 import json
 import os
@@ -8,12 +7,9 @@
 from unittest import mock
 
 import google.protobuf.any_pb2
-import google.protobuf.message
 from google.protobuf import json_format
 
 import temporalio.api.common.v1
-import temporalio.api.enums.v1
-import temporalio.api.errordetails.v1
 import temporalio.api.workflowservice.v1
 import temporalio.common
 import temporalio.exceptions
@@ -33,9 +29,7 @@
     WorkflowTaskFailedCause,
 )
 from temporalio.api.history.v1 import History
-from temporalio.api.workflowservice.v1 import GetSystemInfoRequest, request_response_pb2
-from temporalio.api.batch.v1 import message_pb2
-from temporalio.api.enums.v1 import reset_pb2
+from temporalio.api.workflowservice.v1 import GetSystemInfoRequest
 from temporalio.client import (
     BuildIdOpAddNewCompatible,
     BuildIdOpAddNewDefault,
@@ -44,11 +38,9 @@
     BuildIdOpPromoteSetByBuildId,
     CancelWorkflowInput,
     Client,
-    ClientConfig,
     CloudOperationsClient,
     Interceptor,
     OutboundInterceptor,
-    Plugin,
     QueryWorkflowInput,
     RPCError,
     RPCStatusCode,
@@ -93,7 +85,6 @@
 from temporalio.testing import WorkflowEnvironment
 from tests.helpers import (
     assert_eq_eventually,
-    assert_eventually,
     ensure_search_attributes_present,
     new_worker,
     worker_versioning_enabled,
@@ -1554,22 +1545,3 @@ async def get_schedule_result() -> Tuple[int, Optional[str]]:
         )
 
         await handle.delete()
-
-
-async def test_workflow_client_start_batch_operation(client: Client):
-    # This test is used to ensure that the start_batch_operation is wired through
-    # the layers of python -> bridge python -> bridge rust -> core
-    # https://github.com/temporalio/sdk-python/issues/927
-
-    request = request_response_pb2.StartBatchOperationRequest(
-        namespace="default",
-        visibility_query='WorkflowType="test_workflow"',
-        job_id=f"batch-reset-{int(datetime.now().timestamp())}",
-        reason="test",
-        reset_operation=message_pb2.BatchOperationReset(
-            reset_type=reset_pb2.RESET_TYPE_LAST_WORKFLOW_TASK
-        ),
-    )
-
-    response = await client.workflow_service.start_batch_operation(request)
-    assert response is not None

tests/test_service.py

@@ -1,12 +1,16 @@
 import inspect
 import os
 import re
+from datetime import timedelta
+from importlib import import_module
 from typing import Any, Callable, Dict, Mapping, Tuple, Type
 
 import google.protobuf.empty_pb2
 import google.protobuf.message
+import google.protobuf.symbol_database
 import grpc
 import pytest
+from google.protobuf.descriptor import MethodDescriptor
 
 import temporalio
 import temporalio.api.cloud.cloudservice.v1
@@ -19,6 +23,10 @@
 from temporalio.testing import WorkflowEnvironment
 
 
+def _camel_to_snake(name: str) -> str:
+    return re.sub(r"(?<!^)(?=[A-Z])", "_", name).lower()
+
+
 def test_all_grpc_calls_present(client: Client):
     def assert_all_calls_present(
         service: Any,
@@ -111,7 +119,7 @@ def unary_unary(self, method, request_serializer, response_deserializer):
             getattr(self.package, name + "Response"),
         )
         # Camel to snake case
-        name = re.sub(r"(?<!^)(?=[A-Z])", "_", name).lower()
+        name = _camel_to_snake(name)
         self.calls[name] = req_resp
 
 
@@ -157,3 +165,74 @@ async def test_grpc_status(client: Client, env: WorkflowEnvironment):
     assert err.value.grpc_status.details[0].Is(
         temporalio.api.errordetails.v1.NamespaceNotFoundFailure.DESCRIPTOR
     )
+
+
+async def test_rpc_execution_not_unknown(client: Client):
+    """
+    Execute each rpc method and expect a failure, but ensure the failure is not that the rpc method is unknown
+    """
+    sym_db = google.protobuf.symbol_database.Default()
+    service_client = client.service_client
+
+    async def test_method(
+        target_service_name: str, method_descriptor: MethodDescriptor
+    ):
+        if method_descriptor.client_streaming or method_descriptor.server_streaming:
+            # skip streaming calls
+            return
+
+        method_name = _camel_to_snake(method_descriptor.name)
+
+        # get request type and instantiate an empty request
+        request_type = sym_db.GetSymbol(method_descriptor.input_type.full_name)
+        request = request_type()
+
+        # get the appropriate temporal service from the service_client
+        target_service = getattr(service_client, target_service_name)
+
+        # execute rpc and ensure that any exception that occurs is not the
+        # "Unknown RPC call" error which indicates the python and rust rpc components
+        # should be regenerated
+        rpc_call = getattr(target_service, method_name)
+        try:
+            await rpc_call(request, timeout=timedelta(milliseconds=1))
+        except Exception as err:
+            assert (
+                "Unknown RPC call" not in str(err)
+            ), f"Unexpected unknown-RPC error for {target_service_name}.{method_name}: {err}"
+
+    async def test_service(
+        *, proto_module: str, proto_service: str, target_service_name: str
+    ):
+        # load the module and test each method of the specified service
+        module = import_module(proto_module)
+        service_descriptor = module.DESCRIPTOR.services_by_name[proto_service]
+
+        for method_descriptor in service_descriptor.methods:
+            await test_method(target_service_name, method_descriptor)
+
+    await test_service(
+        proto_module="temporalio.api.workflowservice.v1.service_pb2",
+        proto_service="WorkflowService",
+        target_service_name="workflow_service",
+    )
+    await test_service(
+        proto_module="temporalio.api.operatorservice.v1.service_pb2",
+        proto_service="OperatorService",
+        target_service_name="operator_service",
+    )
+    await test_service(
+        proto_module="temporalio.api.cloud.cloudservice.v1.service_pb2",
+        proto_service="CloudService",
+        target_service_name="cloud_service",
+    )
+    await test_service(
+        proto_module="temporalio.api.testservice.v1.service_pb2",
+        proto_service="TestService",
+        target_service_name="test_service",
+    )
+    await test_service(
+        proto_module="temporalio.bridge.proto.health.v1.health_pb2",
+        proto_service="Health",
+        target_service_name="health_service",
+    )