Skip to content

Commit 8a08d64

Browse files
committed
Fix comments
1 parent c07983c commit 8a08d64

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

temporalio/bridge/src/worker.rs

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -68,18 +68,6 @@ pub struct TunerHolder {
6868
local_activity_slot_supplier: SlotSupplier,
6969
}
7070

71-
// pub fn set_task_locals_on_tuner<'a>(py: Python<'a>, tuner: &TunerHolder) -> PyResult<()> {
72-
// // TODO: All suppliers
73-
// if let SlotSupplier::Custom(ref cs) = tuner.workflow_slot_supplier {
74-
// Python::with_gil(|py| {
75-
// let py_obj = cs.inner.as_ref(py);
76-
// py_obj.call_method0("set_task_locals")?;
77-
// Ok(())
78-
// })?;
79-
// };
80-
// Ok(())
81-
// }
82-
8371
#[derive(FromPyObject)]
8472
pub enum SlotSupplier {
8573
FixedSize(FixedSizeSlotSupplier),
@@ -209,7 +197,8 @@ impl CustomSlotSupplier {
209197

210198
// Shouldn't really need this callback nonsense, it should be possible to do this from the pyo3
211199
// asyncio library, but we'd have to vendor the whole thing to make the right improvements. When
212-
// pyo3 is upgraded and we are using
200+
// pyo3 is upgraded and we are using https://github.com/PyO3/pyo3-async-runtimes (the replacement)
201+
// consider upstreaming a way to do this.
213202

214203
#[pyclass]
215204
struct CreatedTaskForSlotCallback {

0 commit comments

Comments
 (0)