Remove useless disable_file parameter for ClientConfig.load

Author: THardy98

temporalio/bridge/src/envconfig.rs

@@ -89,19 +89,14 @@ fn load_client_config_inner(
     py: Python,
     config_source: Option<DataSource>,
     config_file_strict: bool,
-    disable_file: bool,
     env_vars: Option<HashMap<String, String>>,
 ) -> PyResult<PyObject> {
-    let core_config = if disable_file {
-        CoreClientConfig::default()
-    } else {
-        let options = LoadClientConfigOptions {
-            config_source,
-            config_file_strict,
-        };
-        core_load_client_config(options, env_vars.as_ref())
-            .map_err(|e| ConfigError::new_err(format!("{e}")))?
+    let options = LoadClientConfigOptions {
+        config_source,
+        config_file_strict,
     };
+    let core_config = core_load_client_config(options, env_vars.as_ref())
+        .map_err(|e| ConfigError::new_err(format!("{e}")))?;
 
     core_config_to_dict(py, &core_config)
 }
@@ -130,12 +125,11 @@ fn load_client_connect_config_inner(
 }
 
 #[pyfunction]
-#[pyo3(signature = (path, data, disable_file, config_file_strict, env_vars = None))]
+#[pyo3(signature = (path, data, config_file_strict, env_vars = None))]
 pub fn load_client_config(
     py: Python,
     path: Option<String>,
     data: Option<Vec<u8>>,
-    disable_file: bool,
     config_file_strict: bool,
     env_vars: Option<HashMap<String, String>>,
 ) -> PyResult<PyObject> {
@@ -153,7 +147,6 @@ pub fn load_client_config(
         py,
         config_source,
         config_file_strict,
-        disable_file,
         env_vars,
     )
 }

temporalio/envconfig.py

@@ -333,7 +333,6 @@ def from_dict(
     def load(
         *,
         config_source: Optional[DataSource] = None,
-        disable_file: bool = False,
         config_file_strict: bool = False,
         override_env_vars: Optional[Mapping[str, str]] = None,
     ) -> ClientConfig:
@@ -348,8 +347,6 @@ def load(
             config_source: If present, this is used as the configuration source
                 instead of default file locations. This can be a path to the file
                 or the string/byte contents of the file.
-            disable_file: If true, file loading is disabled. This is only used
-                when ``config_source`` is not present.
             config_file_strict: If true, will TOML file parsing will error on
                 unrecognized keys.
             override_env_vars: The environment variables to use for locating the
@@ -364,7 +361,6 @@ def load(
         loaded_profiles = _bridge_envconfig.load_client_config(
             path=path,
             data=data,
-            disable_file=disable_file,
             config_file_strict=config_file_strict,
             env_vars=override_env_vars,
         )

tests/test_envconfig.py

@@ -285,13 +285,6 @@ def test_load_profiles_discovery(tmp_path: Path, monkeypatch):  # type: ignore[r
     assert "default" in client_config.profiles
 
 
-def test_load_profiles_disable_file():
-    """Test load_profiles with file loading disabled."""
-    # With no env vars, should be empty
-    client_config = ClientConfig.load(disable_file=True, override_env_vars={})
-    assert not client_config.profiles
-
-
 def test_load_profiles_strict_mode_fail(tmp_path: Path):
     """Test that strict mode fails on unrecognized keys."""
     config_file = tmp_path / "config.toml"