Cleanup

Author: dandavison

temporalio/client.py

@@ -6511,9 +6511,9 @@ async def fail_async_activity(self, input: FailAsyncActivityInput) -> None:
         failure = temporalio.api.failure.v1.Failure()
         await data_converter.encode_failure(input.error, failure)
         last_heartbeat_details = (
-            None
-            if not input.last_heartbeat_details
-            else await data_converter.encode_wrapper(input.last_heartbeat_details)
+            await data_converter.encode_wrapper(input.last_heartbeat_details)
+            if input.last_heartbeat_details
+            else None
         )
         if isinstance(input.id_or_token, AsyncActivityIDReference):
             await self._client.workflow_service.respond_activity_task_failed_by_id(

temporalio/converter.py

@@ -72,21 +72,17 @@ class SerializationContext(ABC):
     Provides contextual information during serialization and deserialization operations.
 
     Examples:
-
     - In client code, when starting a workflow, or sending a signal/update/query to a workflow, or
       receiving the result of an update/query, or handling an exception from a workflow, the context
       type is :py:class:`WorkflowSerializationContext` and the workflow ID set of the target
       workflow will be set in the context.
-
     - In workflow code, when operating on a payload being sent/received to/from a child workflow, or
       handling an exception from a child workflow, the context type is
       :py:class:`WorkflowSerializationContext` and the workflow ID is that of the child workflow,
       not of the currently executing (i.e. parent) workflow.
-
     - In workflow code, when operating on a payload to be sent/received to/from an activity, the
       context type is :py:class:`ActivitySerializationContext` and the workflow ID is that of the
       currently-executing workflow. ActivitySerializationContext is also set on operations
-
     """
 
     pass
@@ -407,11 +403,11 @@ def from_payloads(
 
     def with_context(self, context: Optional[SerializationContext]) -> Self:
         """Return a new instance with the given context."""
-        instance = type(self).__new__(type(self))
         converters = [
             c.with_context(context) if isinstance(c, WithSerializationContext) else c
             for c in self.converters.values()
         ]
+        instance = type(self).__new__(type(self))
         CompositePayloadConverter.__init__(instance, *converters)
         return instance