Test: give time for handler wf events and change assertions

Author: dandavison

tests/nexus/test_workflow_caller_cancellation_types.py

@@ -80,6 +80,8 @@ async def run(self, input: Input) -> CancellationResult:
             await op_handle
         except exceptions.NexusOperationError:
             caller_unblock_time = workflow.now()
+            # Give time for handler wf cancellation event to be written if a request was sent
+            await asyncio.sleep(0.5)
             assert op_handle.operation_token
             return CancellationResult(
                 operation_token=op_handle.operation_token,
@@ -96,7 +98,6 @@ async def check_behavior_for_abandon(
     """
     Check that a cancellation request is not sent.
     """
-    await asyncio.sleep(0.5)
     handler_status = (await handler_wf.describe()).status
     assert handler_status == WorkflowExecutionStatus.RUNNING
     await _assert_event_subsequence(
@@ -120,19 +121,18 @@ async def check_behavior_for_try_cancel(
     canceled.
     """
     handler_status = (await handler_wf.describe()).status
-    assert handler_status == WorkflowExecutionStatus.RUNNING
+    assert handler_status == WorkflowExecutionStatus.CANCELED
     await _assert_event_subsequence(
         [
             (caller_wf, EventType.EVENT_TYPE_WORKFLOW_EXECUTION_STARTED),
             (caller_wf, EventType.EVENT_TYPE_NEXUS_OPERATION_CANCEL_REQUESTED),
+            (
+                handler_wf,
+                EventType.EVENT_TYPE_WORKFLOW_EXECUTION_CANCEL_REQUESTED,
+            ),
             (caller_wf, EventType.EVENT_TYPE_WORKFLOW_EXECUTION_COMPLETED),
         ]
     )
-    # This event would be seen if the caller workflow stayed alive longer.
-    assert not await _has_event(
-        handler_wf,
-        EventType.EVENT_TYPE_WORKFLOW_EXECUTION_CANCEL_REQUESTED,
-    )
 
 
 async def check_behavior_for_wait_cancellation_completed(