Change on_*_create to configure_*

Author: tconley1428

temporalio/client.py

@@ -189,7 +189,7 @@ async def connect(
         )
 
         root_plugin: Plugin = _RootPlugin()
-        for plugin in reversed(list(plugins)):
+        for plugin in reversed(plugins):
             root_plugin = plugin.init_client_plugin(root_plugin)
 
         service_client = await root_plugin.connect_service_client(connect_config)
@@ -233,10 +233,10 @@ def __init__(
         )
 
         root_plugin: Plugin = _RootPlugin()
-        for plugin in reversed(list(plugins)):
+        for plugin in reversed(plugins):
             root_plugin = plugin.init_client_plugin(root_plugin)
 
-        self._init_from_config(root_plugin.on_create_client(config))
+        self._init_from_config(root_plugin.configure_client(config))
 
     def _init_from_config(self, config: ClientConfig):
         self._config = config
@@ -7433,7 +7433,7 @@ def init_client_plugin(self, next: Plugin) -> Plugin:
         self.next_client_plugin = next
         return self
 
-    def on_create_client(self, config: ClientConfig) -> ClientConfig:
+    def configure_client(self, config: ClientConfig) -> ClientConfig:
         """Hook called when creating a client to allow modification of configuration.
 
         This method is called during client creation and allows plugins to modify
@@ -7446,7 +7446,7 @@ def on_create_client(self, config: ClientConfig) -> ClientConfig:
         Returns:
             The modified client configuration.
         """
-        return self.next_client_plugin.on_create_client(config)
+        return self.next_client_plugin.configure_client(config)
 
     async def connect_service_client(
         self, config: temporalio.service.ConnectConfig
@@ -7467,7 +7467,7 @@ async def connect_service_client(
 
 
 class _RootPlugin(Plugin):
-    def on_create_client(self, config: ClientConfig) -> ClientConfig:
+    def configure_client(self, config: ClientConfig) -> ClientConfig:
         return config
 
     async def connect_service_client(

temporalio/worker/_worker.py

@@ -128,7 +128,7 @@ def init_worker_plugin(self, next: Plugin) -> Plugin:
         self.next_worker_plugin = next
         return self
 
-    def on_create_worker(self, config: WorkerConfig) -> WorkerConfig:
+    def configure_worker(self, config: WorkerConfig) -> WorkerConfig:
         """Hook called when creating a worker to allow modification of configuration.
 
         This method is called during worker creation and allows plugins to modify
@@ -142,7 +142,7 @@ def on_create_worker(self, config: WorkerConfig) -> WorkerConfig:
         Returns:
             The modified worker configuration.
         """
-        return self.next_worker_plugin.on_create_worker(config)
+        return self.next_worker_plugin.configure_worker(config)
 
     async def run_worker(self, worker: Worker) -> None:
         """Hook called when running a worker to allow interception of execution.
@@ -158,7 +158,7 @@ async def run_worker(self, worker: Worker) -> None:
 
 
 class _RootPlugin(Plugin):
-    def on_create_worker(self, config: WorkerConfig) -> WorkerConfig:
+    def configure_worker(self, config: WorkerConfig) -> WorkerConfig:
         return config
 
     async def run_worker(self, worker: Worker) -> None:
@@ -449,9 +449,9 @@ def __init__(
         plugins = plugins_from_client + list(plugins)
 
         root_plugin: Plugin = _RootPlugin()
-        for plugin in reversed(list(plugins)):
+        for plugin in reversed(plugins):
             root_plugin = plugin.init_worker_plugin(root_plugin)
-        config = root_plugin.on_create_worker(config)
+        config = root_plugin.configure_worker(config)
         self._plugin = root_plugin
 
         self._init_from_config(config)

tests/test_plugins.py

@@ -4,30 +4,31 @@
 
 import temporalio.client
 import temporalio.worker
-from temporalio.client import Client, ClientConfig, OutboundInterceptor, Plugin
+from temporalio.client import Client, ClientConfig, OutboundInterceptor
 from temporalio.testing import WorkflowEnvironment
 from temporalio.worker import Worker, WorkerConfig
 from tests.worker.test_worker import never_run_activity
 
 
 class TestClientInterceptor(temporalio.client.Interceptor):
+    __test__ = False
     intercepted = False
 
     def intercept_client(self, next: OutboundInterceptor) -> OutboundInterceptor:
         self.intercepted = True
         return super().intercept_client(next)
 
 
-class MyClientPlugin(Plugin):
+class MyClientPlugin(temporalio.client.Plugin):
     def __init__(self):
         self.interceptor = TestClientInterceptor()
 
-    def on_create_client(self, config: ClientConfig) -> ClientConfig:
+    def configure_client(self, config: ClientConfig) -> ClientConfig:
         config["namespace"] = "replaced_namespace"
         config["interceptors"] = list(config.get("interceptors") or []) + [
             self.interceptor
         ]
-        return super().on_create_client(config)
+        return super().configure_client(config)
 
     async def connect_service_client(
         self, config: temporalio.service.ConnectConfig
@@ -55,15 +56,15 @@ async def test_client_plugin(client: Client, env: WorkflowEnvironment):
 
 
 class MyCombinedPlugin(temporalio.client.Plugin, temporalio.worker.Plugin):
-    def on_create_worker(self, config: WorkerConfig) -> WorkerConfig:
+    def configure_worker(self, config: WorkerConfig) -> WorkerConfig:
         config["task_queue"] = "combined"
-        return super().on_create_worker(config)
+        return super().configure_worker(config)
 
 
 class MyWorkerPlugin(temporalio.worker.Plugin):
-    def on_create_worker(self, config: WorkerConfig) -> WorkerConfig:
+    def configure_worker(self, config: WorkerConfig) -> WorkerConfig:
         config["task_queue"] = "replaced_queue"
-        return super().on_create_worker(config)
+        return super().configure_worker(config)
 
     async def run_worker(self, worker: Worker) -> None:
         await super().run_worker(worker)