Store data_converter on WorkflowInstanceDetails instead of converter classes

Author: dandavison

temporalio/worker/_workflow.py

@@ -565,8 +565,7 @@ def _create_workflow_instance(
 
         # Create instance from details
         det = WorkflowInstanceDetails(
-            payload_converter_class=self._data_converter.payload_converter_class,
-            failure_converter_class=self._data_converter.failure_converter_class,
+            data_converter=self._data_converter,
             interceptor_classes=self._interceptor_classes,
             defn=defn,
             info=info,

temporalio/worker/_workflow_instance.py

@@ -135,8 +135,7 @@ def set_worker_level_failure_exception_types(
 class WorkflowInstanceDetails:
     """Immutable details for creating a workflow instance."""
 
-    payload_converter_class: Type[temporalio.converter.PayloadConverter]
-    failure_converter_class: Type[temporalio.converter.FailureConverter]
+    data_converter: temporalio.converter.DataConverter
     interceptor_classes: Sequence[Type[WorkflowInboundInterceptor]]
     defn: temporalio.workflow._Definition
     info: temporalio.workflow.Info
@@ -210,8 +209,12 @@ def __init__(self, det: WorkflowInstanceDetails) -> None:
         self._defn = det.defn
         self._workflow_input: Optional[ExecuteWorkflowInput] = None
         self._info = det.info
-        self._context_free_payload_converter = det.payload_converter_class()
-        self._context_free_failure_converter = det.failure_converter_class()
+        self._context_free_payload_converter = (
+            det.data_converter.payload_converter_class()
+        )
+        self._context_free_failure_converter = (
+            det.data_converter.failure_converter_class()
+        )
         self._payload_converter, self._failure_converter = (
             self._converters_with_context(
                 temporalio.converter.WorkflowSerializationContext(

temporalio/worker/workflow_sandbox/_runner.py

@@ -77,8 +77,7 @@ def prepare_workflow(self, defn: temporalio.workflow._Definition) -> None:
         # Just create with fake info which validates
         self.create_instance(
             WorkflowInstanceDetails(
-                payload_converter_class=temporalio.converter.DataConverter.default.payload_converter_class,
-                failure_converter_class=temporalio.converter.DataConverter.default.failure_converter_class,
+                data_converter=temporalio.converter.DataConverter.default,
                 interceptor_classes=[],
                 defn=defn,
                 # Just use fake info during validation