Rename plugin + a few fixes

Author: tconley1428

temporalio/contrib/openai_agents/__init__.py

@@ -10,15 +10,15 @@
 
 from temporalio.contrib.openai_agents._model_parameters import ModelActivityParameters
 from temporalio.contrib.openai_agents.temporal_openai_agents import (
-    Plugin,
+    OpenAIAgentsPlugin,
     TestModel,
     TestModelProvider,
 )
 
 from . import workflow
 
 __all__ = [
-    "Plugin",
+    "OpenAIAgentsPlugin",
     "ModelActivityParameters",
     "workflow",
     "TestModel",

temporalio/contrib/openai_agents/temporal_openai_agents.py

@@ -144,7 +144,7 @@ def stream_response(
         raise NotImplementedError()
 
 
-class Plugin(temporalio.client.Plugin, temporalio.worker.Plugin):
+class OpenAIAgentsPlugin(temporalio.client.Plugin, temporalio.worker.Plugin):
     """Temporal plugin for integrating OpenAI agents with Temporal workflows.
 
     .. warning::
@@ -171,7 +171,7 @@ class Plugin(temporalio.client.Plugin, temporalio.worker.Plugin):
     Example:
         >>> from temporalio.client import Client
         >>> from temporalio.worker import Worker
-        >>> from temporalio.contrib.openai_agents import Plugin, ModelActivityParameters
+        >>> from temporalio.contrib.openai_agents import OpenAIAgentsPlugin, ModelActivityParameters
         >>> from datetime import timedelta
         >>>
         >>> # Configure model parameters
@@ -181,7 +181,7 @@ class Plugin(temporalio.client.Plugin, temporalio.worker.Plugin):
         ... )
         >>>
         >>> # Create plugin
-        >>> plugin = Plugin(model_params=model_params)
+        >>> plugin = OpenAIAgentsPlugin(model_params=model_params)
         >>>
         >>> # Use with client and worker
         >>> client = await Client.connect(
@@ -192,7 +192,6 @@ class Plugin(temporalio.client.Plugin, temporalio.worker.Plugin):
         ...     client,
         ...     task_queue="my-task-queue",
         ...     workflows=[MyWorkflow],
-        ...     plugins=[plugin]
         ... )
     """
 

tests/contrib/openai_agents/test_openai.py

@@ -124,7 +124,7 @@ async def test_hello_world_agent(client: Client, use_local_model: bool):
         pytest.skip("No openai API key")
     new_config = client.config()
     new_config["plugins"] = [
-        openai_agents.Plugin(
+        openai_agents.OpenAIAgentsPlugin(
             model_params=ModelActivityParameters(
                 start_to_close_timeout=timedelta(seconds=30)
             ),
@@ -412,7 +412,7 @@ async def test_tool_workflow(client: Client, use_local_model: bool):
         pytest.skip("No openai API key")
     new_config = client.config()
     new_config["plugins"] = [
-        openai_agents.Plugin(
+        openai_agents.OpenAIAgentsPlugin(
             model_params=ModelActivityParameters(
                 start_to_close_timeout=timedelta(seconds=30)
             ),
@@ -532,7 +532,7 @@ async def test_nexus_tool_workflow(
 
     new_config = client.config()
     new_config["plugins"] = [
-        openai_agents.Plugin(
+        openai_agents.OpenAIAgentsPlugin(
             model_params=ModelActivityParameters(
                 start_to_close_timeout=timedelta(seconds=30)
             ),
@@ -678,7 +678,7 @@ async def test_research_workflow(client: Client, use_local_model: bool):
         pytest.skip("No openai API key")
     new_config = client.config()
     new_config["plugins"] = [
-        openai_agents.Plugin(
+        openai_agents.OpenAIAgentsPlugin(
             model_params=ModelActivityParameters(
                 start_to_close_timeout=timedelta(seconds=30)
             ),
@@ -892,7 +892,7 @@ async def test_agents_as_tools_workflow(client: Client, use_local_model: bool):
         pytest.skip("No openai API key")
     new_config = client.config()
     new_config["plugins"] = [
-        openai_agents.Plugin(
+        openai_agents.OpenAIAgentsPlugin(
             model_params=ModelActivityParameters(
                 start_to_close_timeout=timedelta(seconds=30)
             ),
@@ -1244,7 +1244,7 @@ async def test_customer_service_workflow(client: Client, use_local_model: bool):
         pytest.skip("No openai API key")
     new_config = client.config()
     new_config["plugins"] = [
-        openai_agents.Plugin(
+        openai_agents.OpenAIAgentsPlugin(
             model_params=ModelActivityParameters(
                 start_to_close_timeout=timedelta(seconds=30)
             ),
@@ -1534,7 +1534,7 @@ async def test_input_guardrail(client: Client, use_local_model: bool):
         pytest.skip("No openai API key")
     new_config = client.config()
     new_config["plugins"] = [
-        openai_agents.Plugin(
+        openai_agents.OpenAIAgentsPlugin(
             model_params=ModelActivityParameters(
                 start_to_close_timeout=timedelta(seconds=30)
             ),
@@ -1649,7 +1649,7 @@ async def test_output_guardrail(client: Client, use_local_model: bool):
         pytest.skip("No openai API key")
     new_config = client.config()
     new_config["plugins"] = [
-        openai_agents.Plugin(
+        openai_agents.OpenAIAgentsPlugin(
             model_params=ModelActivityParameters(
                 start_to_close_timeout=timedelta(seconds=30)
             ),
@@ -1737,7 +1737,7 @@ async def run_tool(self):
 async def test_workflow_method_tools(client: Client):
     new_config = client.config()
     new_config["plugins"] = [
-        openai_agents.Plugin(
+        openai_agents.OpenAIAgentsPlugin(
             model_params=ModelActivityParameters(
                 start_to_close_timeout=timedelta(seconds=30)
             ),

tests/contrib/openai_agents/test_openai_tracing.py

@@ -41,7 +41,7 @@ def force_flush(self) -> None:
 async def test_tracing(client: Client):
     new_config = client.config()
     new_config["plugins"] = [
-        openai_agents.Plugin(model_provider=TestModelProvider(TestResearchModel()))
+        openai_agents.OpenAIAgentsPlugin(model_provider=TestModelProvider(TestResearchModel()))
     ]
     client = Client(**new_config)
 

tests/test_client.py

@@ -1501,15 +1501,3 @@ async def test_cloud_client_simple():
         GetNamespaceRequest(namespace=os.environ["TEMPORAL_CLIENT_CLOUD_NAMESPACE"])
     )
     assert os.environ["TEMPORAL_CLIENT_CLOUD_NAMESPACE"] == result.namespace.namespace
-
-
-class MyPlugin(Plugin):
-    def configure_client(self, config: ClientConfig) -> ClientConfig:
-        config["namespace"] = "replaced_namespace"
-        return super().configure_client(config)
-
-    async def connect_service_client(
-        self, config: temporalio.service.ConnectConfig
-    ) -> temporalio.service.ServiceClient:
-        config.api_key = "replaced key"
-        return await super().connect_service_client(config)