Skip to content

Commit c2d3eb9

Browse files
committed
Move visitor, bridge client generation, and formatting to poe tasks
1 parent 26e2e61 commit c2d3eb9

File tree

4 files changed

+14
-22
lines changed

4 files changed

+14
-22
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ jobs:
117117
uv sync --all-extras
118118
poe build-develop
119119
poe gen-protos
120-
poe format
121120
[[ -z $(git status --porcelain temporalio) ]] || (git diff temporalio; echo "Protos changed"; exit 1)
122121
poe test -s
123122
timeout-minutes: 10

pyproject.toml

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,21 @@ build-develop-with-release = { cmd = "uv run maturin develop --release --uv" }
6161
format = [
6262
{ cmd = "uv run ruff check --select I --fix" },
6363
{ cmd = "uv run ruff format" },
64+
{ cmd = "cargo fmt", cwd = "temporalio/bridge" },
6465
]
6566
gen-docs = "uv run scripts/gen_docs.py"
66-
gen-protos = "uv run scripts/gen_protos.py"
67-
gen-protos-docker = "uv run scripts/gen_protos_docker.py"
67+
gen-protos = [
68+
{ cmd = "uv run scripts/gen_protos.py" },
69+
{ cmd = "uv run scripts/gen_payload_visitor.py" },
70+
{ cmd = "uv run scripts/gen_bridge_client.py" },
71+
{ ref = "format" },
72+
]
73+
gen-protos-docker = [
74+
{ cmd = "uv run scripts/gen_protos_docker.py" },
75+
{ cmd = "uv run scripts/gen_payload_visitor.py" },
76+
{ cmd = "uv run scripts/gen_bridge_client.py" },
77+
{ ref = "format" },
78+
]
6879
lint = [
6980
{ cmd = "uv run ruff check --select I" },
7081
{ cmd = "uv run ruff format --check" },

scripts/_proto/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ COPY ./ ./
1010
RUN mkdir -p ./temporalio/api
1111
RUN uv add "protobuf<4"
1212
RUN uv sync --all-extras
13-
RUN poe gen-protos
13+
RUN uv run scripts/gen_protos.py
1414

1515
CMD ["sh", "-c", "cp -r ./temporalio/api/* /api_new && cp -r ./temporalio/bridge/proto/* /bridge_new"]

scripts/gen_protos_docker.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -30,21 +30,3 @@
3030
],
3131
check=True,
3232
)
33-
34-
subprocess.run(
35-
["uv", "run", os.path.join(os.getcwd(), "scripts", "gen_payload_visitor.py")],
36-
check=True,
37-
)
38-
39-
subprocess.run(
40-
["uv", "run", os.path.join(os.getcwd(), "scripts", "gen_bridge_client.py")],
41-
check=True,
42-
)
43-
44-
subprocess.run(["uv", "run", "poe", "format"], check=True)
45-
46-
subprocess.run(
47-
["cargo", "fmt"],
48-
check=True,
49-
cwd=os.path.join(os.getcwd(), "temporalio", "bridge"),
50-
)

0 commit comments

Comments
 (0)