Fix: Resolve TypeError in value_to_type on Python 3.13 (issue #1188)

Author: BrunodsLilly

temporalio/converter.py

@@ -1766,7 +1766,11 @@ def value_to_type(
 
                     # Can't call isinstance if key_type is a newtype
                     is_newtype = getattr(key_type, "__supertype__", None)
-                    if is_newtype or not isinstance(key, key_type):
+                    if (
+                        is_newtype
+                        or not isinstance(key_type, type)
+                        or not isinstance(key, key_type)
+                    ):
                         key = value_to_type(key_type, key, custom_converters)
                 except Exception as err:
                     raise TypeError(

tests/test_converter.py

@@ -671,3 +671,29 @@ async def test_json_type_converter():
     assert [addr, addr] == (
         await custom_conv.decode([list_payload], [List[ipaddress.IPv4Address]])
     )[0]
+
+
+def test_value_to_type_literal_key():
+    # The type for the dictionary's *key*:
+    KeyHint = Literal[
+        "Key1",
+        "Key2",
+    ]
+
+    # The type for the dictionary's *value* (the inner dict):
+    InnerKeyHint = Literal[
+        "Inner1",
+        "Inner2",
+    ]
+    InnerValueHint = str | int | float | None
+    ValueHint = dict[InnerKeyHint, InnerValueHint]
+
+    # The full type hint for the mapping:
+    hint_with_bug = dict[KeyHint, ValueHint]
+
+    # A value that uses one of the literal keys:
+    value_to_convert = {"Key1": {"Inner1": 123.45, "Inner2": 10}}
+    custom_converters = []
+
+    # Function executes without error
+    value_to_type(hint_with_bug, value_to_convert, custom_converters)