Move tracing uuids to use a separate Random from the workflow seed

Author: tconley1428

temporalio/contrib/openai_agents/_temporal_trace_provider.py

@@ -1,8 +1,10 @@
 """Provides support for integration with OpenAI Agents SDK tracing across workflows"""
 
 import uuid
+from random import Random
 from types import TracebackType
 from typing import Any, Optional, cast
+from uuid import UUID
 
 from agents import SpanData, Trace, TracingProcessor
 from agents.tracing import (
@@ -133,6 +135,15 @@ def force_flush(self) -> None:
         self._impl.force_flush()
 
 
+def _workflow_uuid() -> str:
+    random = cast(
+        Random, getattr(workflow.instance(), "__temporal_openai_tracing_random")
+    )
+    return UUID(bytes=random.getrandbits(16 * 8).to_bytes(16, "big"), version=4).hex[
+        :24
+    ]
+
+
 class TemporalTraceProvider(DefaultTraceProvider):
     """A trace provider that integrates with Temporal workflows."""
 
@@ -156,7 +167,7 @@ def gen_trace_id(self) -> str:
         if workflow.in_workflow():
             try:
                 """Generate a new trace ID."""
-                return f"trace_{workflow.uuid4().hex}"
+                return f"trace_{_workflow_uuid()}"
             except ReadOnlyContextError:
                 return f"trace_{uuid.uuid4().hex}"
         return super().gen_trace_id()
@@ -166,7 +177,7 @@ def gen_span_id(self) -> str:
         if workflow.in_workflow():
             try:
                 """Generate a deterministic span ID."""
-                return f"span_{workflow.uuid4().hex[:24]}"
+                return f"span_{_workflow_uuid()}"
             except ReadOnlyContextError:
                 return f"span_{uuid.uuid4().hex[:24]}"
         return super().gen_span_id()
@@ -176,7 +187,7 @@ def gen_group_id(self) -> str:
         if workflow.in_workflow():
             try:
                 """Generate a deterministic group ID."""
-                return f"group_{workflow.uuid4().hex[:24]}"
+                return f"group_{_workflow_uuid()}"
             except ReadOnlyContextError:
                 return f"group_{uuid.uuid4().hex[:24]}"
         return super().gen_group_id()

temporalio/contrib/openai_agents/_trace_interceptor.py

@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import random
 from contextlib import contextmanager
 from typing import Any, Mapping, Protocol, Type, cast
 
@@ -283,6 +284,18 @@ async def execute_activity(
             return await self.next.execute_activity(input)
 
 
+def _ensure_tracing_random() -> None:
+    instance = workflow.instance()
+    if not hasattr(instance, "__temporal_openai_tracing_random"):
+        new_random = random.Random()
+        new_random.setstate(workflow.random().getstate())
+        setattr(
+            workflow.instance(),
+            "__temporal_openai_tracing_random",
+            new_random,
+        )
+
+
 class _ContextPropagationWorkflowInboundInterceptor(
     temporalio.worker.WorkflowInboundInterceptor
 ):
@@ -292,18 +305,21 @@ def init(self, outbound: temporalio.worker.WorkflowOutboundInterceptor) -> None:
     async def execute_workflow(
         self, input: temporalio.worker.ExecuteWorkflowInput
     ) -> Any:
+        _ensure_tracing_random()
         with context_from_header(
             "temporal:executeWorkflow", input, temporalio.workflow.payload_converter()
         ):
             return await self.next.execute_workflow(input)
 
     async def handle_signal(self, input: temporalio.worker.HandleSignalInput) -> None:
+        _ensure_tracing_random()
         with context_from_header(
             "temporal:handleSignal", input, temporalio.workflow.payload_converter()
         ):
             return await self.next.handle_signal(input)
 
     async def handle_query(self, input: temporalio.worker.HandleQueryInput) -> Any:
+        _ensure_tracing_random()
         with context_from_header(
             "temporal:handleQuery", input, temporalio.workflow.payload_converter()
         ):
@@ -322,6 +338,7 @@ def handle_update_validator(
     async def handle_update_handler(
         self, input: temporalio.worker.HandleUpdateInput
     ) -> Any:
+        _ensure_tracing_random()
         with context_from_header(
             "temporal:handleUpdateHandler",
             input,