Skip to content

Commit fe25627

Browse files
committed
Bug fix
1 parent cdfd725 commit fe25627

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

temporalio/worker/_workflow.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,8 @@ async def _handle_activation(
254254
temporalio.bridge.proto.workflow_completion.WorkflowActivationCompletion()
255255
)
256256
completion.successful.SetInParent()
257-
workflow = workflow_id = None
257+
workflow = None
258+
data_converter = self._data_converter
258259
try:
259260
if LOG_PROTOS:
260261
logger.debug("Received workflow activation:\n%s", act)
@@ -274,9 +275,16 @@ async def _handle_activation(
274275
"Cache already exists for activation with initialize job"
275276
)
276277

278+
data_converter = self._data_converter._with_context(
279+
temporalio.converter.WorkflowSerializationContext(
280+
namespace=self._namespace,
281+
workflow_id=workflow_id,
282+
)
283+
)
277284
if self._data_converter.payload_codec:
285+
assert data_converter.payload_codec
278286
if not workflow:
279-
payload_codec = self._data_converter.payload_codec
287+
payload_codec = data_converter.payload_codec
280288
else:
281289
payload_codec = _CommandAwarePayloadCodec(
282290
workflow.instance,
@@ -335,14 +343,6 @@ async def _handle_activation(
335343

336344
completion.failed.failure.SetInParent()
337345
try:
338-
data_converter = self._data_converter
339-
if workflow_id:
340-
data_converter = data_converter._with_context(
341-
temporalio.converter.WorkflowSerializationContext(
342-
namespace=self._namespace,
343-
workflow_id=workflow_id,
344-
)
345-
)
346346
data_converter.failure_converter.to_failure(
347347
err,
348348
data_converter.payload_converter,

0 commit comments

Comments
 (0)