Fix model replacement on looping handoffs #1122
Merged
+99
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrectly in the workflow
dandavison
approved these changes
Sep 25, 2025
Contributor
dandavison
left a comment
dandavison
left a comment
There was a problem hiding this comment.
Nice, approved but I do think the instances should be used directly in the hash table lookup unless there's a reason not to.
robholland
added a commit
to robholland/oai-temporal-wealth-management
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Changed the agent conversion logic to keep "to be replaced" agents in memory so they can be replaced in looping handoffs
Why?
Without this, when a handoff loops back to an earlier agent, it will not have had its model replaced, resulting in an attempt to use a standard model rather than the temporal wrapper
Checklist
Closes
How was this tested:
New end to end scenario on customer service and unit test of conversion.
Any docs updates needed?