-
Notifications
You must be signed in to change notification settings - Fork 141
Remove file exclusions for pyright #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… errors - Remove temporalio/bridge/worker.py from pyproject.toml exclude list - Add type ignore comments for reportOptionalMemberAccess errors in Worker class methods - All 12 type errors resolved without functional changes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ype errors - Remove temporalio/worker/_replayer.py from pyproject.toml exclude list - Add missing temporalio.worker import to fix Plugin reference - Replace TypedDict direct access with .get() calls for optional keys - Initialize variables to avoid unbound variable errors in finally block - Use bridge_worker_scope to avoid variable shadowing issues - All 25 type errors resolved without functional changes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…e errors - Remove temporalio/worker/_worker.py from pyproject.toml exclude list - Replace TypedDict direct access with .get() calls for optional keys - Add type ignore comments for required fields and argument type mismatches - Use variable pattern to avoid repeated access after .get() checks - Store results of .get() in variables when followed by direct access - All 81 type errors resolved without functional changes or defaults 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…rter.py - Remove temporalio/worker/workflow_sandbox/_importer.py from pyproject.toml exclude list - File was already type-clean with no errors to fix 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…rictions.py and fix type errors - Remove temporalio/worker/workflow_sandbox/_restrictions.py from pyproject.toml exclude list - Fix variable redeclaration by renaming inner functions from bind_func to _bind_func - Properly assign functions to bind_func variable to match type annotation - All 2 type errors resolved without functional changes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove temporalio/workflow.py from pyproject.toml exclude list - Add missing imports for temporalio.bridge.proto modules - Fix decorator return type annotations for defn, signal, and update - Add type ignore comments for static method cls parameter warnings - Add type ignore comments for complex return type issues in update decorator - All 17 errors and 3 warnings resolved without functional changes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
… errors Fixed 8 type errors: - Added type ignore comments for dict(context.invocation_metadata()) calls - Added type ignore comments for grpc.aio.Server vs grpc.Server mismatch in add_WorkflowServiceServicer_to_server calls 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Fixed 1 type error: - Added type ignore comment for request.config.getoption() return type mismatch 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
File was already type-clean, no fixes needed. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
File was already type-clean, no fixes needed. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
File was already type-clean, no fixes needed. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
File was already type-clean, no fixes needed. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
File was already type-clean, no fixes needed. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Fixed 1 type error: - Added type ignore comment for DataConverter().decode() call with optional type hint 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Fixed 3 type errors: - Added type ignore comments for CallCollectingChannel abstract class usage - Added type ignore comment for unary_unary method override incompatibility - Added type ignore comment for __abstractmethods__ attribute assignment 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ssing imports Fixed 4 type errors by adding missing imports: - Added import temporalio.api.common.v1 - Added import temporalio.exceptions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ter.py File was already type-clean, no fixes needed. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ictions.py File was already type-clean, no fixes needed. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
VegetarianOrc
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Removed exclusions for non autogenerated files and either fixed or ignored all errors.
Why?
Checklist
Closes
How was this tested: