Skip to content

upload nightly tps metrics to s3 #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
THardy98 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

upload nightly tps metrics to s3 #1242

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbb1215
upload nightly tps metrics to s3
THardy98 Dec 5, 2025
d0407c9
use env vars instead of var interpolation, add is_experiment input
THardy98 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 35 additions & 3 deletions .github/workflows/nightly-throughput-stress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ on:
schedule:
# Run at 3 AM PST (11:00 UTC) - offset from existing nightly
- cron: '00 11 * * *'
push:
branches:
- add-nightly-throughput-stress-workflow
workflow_dispatch:
inputs:
duration:
Expand All @@ -33,6 +30,9 @@ env:
TEST_DURATION: ${{ inputs.duration || vars.NIGHTLY_TEST_DURATION || '5h' }}
TEST_TIMEOUT: ${{ inputs.timeout || vars.NIGHTLY_TEST_TIMEOUT || '5h30m' }}

# AWS S3 metrics upload ARN
AWS_S3_METRICS_UPLOAD_ROLE_ARN: ${{ vars.AWS_S3_METRICS_UPLOAD_ROLE_ARN }}

# Logging and artifacts
WORKER_LOG_DIR: /tmp/throughput-stress-logs

Expand Down Expand Up @@ -107,6 +107,14 @@ jobs:
- name: Install Temporal CLI
uses: temporalio/setup-temporal@v0

- name: Install Prometheus
run: |
PROM_VERSION="3.8.0"
Copy link
Contributor

@VegetarianOrc VegetarianOrc Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider moving this up to the env block (either for this step or even the workflow) rather than defining it inline here.

Copy link
Contributor Author

@THardy98 THardy98 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also moved to env var

wget -q https://github.com/prometheus/prometheus/releases/download/v${PROM_VERSION}/prometheus-${PROM_VERSION}.linux-amd64.tar.gz
tar xzf prometheus-${PROM_VERSION}.linux-amd64.tar.gz
sudo mv prometheus-${PROM_VERSION}.linux-amd64/prometheus /usr/local/bin/
prometheus --version

- name: Setup log directory
run: mkdir -p $WORKER_LOG_DIR

Expand Down Expand Up @@ -139,13 +147,37 @@ jobs:
--duration $TEST_DURATION \
--timeout $TEST_TIMEOUT \
--max-concurrent 10 \
--prom-listen-address 127.0.0.1:9091 \
--worker-prom-listen-address 127.0.0.1:9092 \
--prom-instance-addr 127.0.0.1:9090 \
--prom-instance-config \
--prom-export-worker-metrics $RUN_ID.parquet \
--option internal-iterations=10 \
--option continue-as-new-after-iterations=3 \
--option sleep-time=1s \
--option visibility-count-timeout=5m \
--option min-throughput-per-hour=1000 \
2>&1 | tee $WORKER_LOG_DIR/scenario.log

- name: Configure AWS credentials
if: always()
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ env.AWS_S3_METRICS_UPLOAD_ROLE_ARN }}
aws-region: us-west-2

- name: Upload metrics to S3
if: always()
run: |
DATE=$(date +%Y-%m-%d)
# Use test/ prefix on non-main branches
PREFIX="language=python/date=$DATE"
if [[ "${{ github.ref }}" != "refs/heads/main" ]]; then
Copy link
Contributor

@VegetarianOrc VegetarianOrc Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think github.ref might be safe in this context, but IMO we should be in the habit of piping any interpolation through env vars to avoid any potential injection

Copy link
Contributor Author

@THardy98 THardy98 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to env var

PREFIX="test/$PREFIX"
fi
aws s3 cp omes/$RUN_ID.parquet \
"s3://cloud-data-ingest-prod/github/sdk_load_test/$PREFIX/$RUN_ID.parquet"

- name: Upload logs on failure
if: failure() || cancelled()
uses: actions/upload-artifact@v4
Expand Down
Loading