Skip to content

Set run id in update handle #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Set run id in update handle #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8994143
Add assertion to existing test
dandavison Dec 19, 2024
1c1c8a0
Set run ID in update handle
dandavison Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion temporalio/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5412,7 +5412,7 @@ async def start_workflow_update(
client=self._client,
id=req.request.meta.update_id,
workflow_id=input.id,
workflow_run_id=input.run_id,
workflow_run_id=resp.update_ref.workflow_execution.run_id,
result_type=input.ret_type,
)
if resp.HasField("outcome"):
Expand Down
2 changes: 2 additions & 0 deletions tests/worker/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4590,6 +4590,8 @@ async def test_workflow_update_separate_handle(
wait_for_stage=WorkflowUpdateStage.ACCEPTED,
)

assert update_handle_1.workflow_run_id == handle.first_execution_run_id

# Create another handle and have them both wait for update complete
update_handle_2 = client.get_workflow_handle(
handle.id, run_id=handle.result_run_id
Expand Down
Loading