Skip to content

Use non-test name for workflow classes #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dandavison merged 1 commit into from
Jan 18, 2025
+8 −8
Merged

Use non-test name for workflow classes #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tests/worker/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5841,7 +5841,7 @@ async def test_workflow_id_conflict(client: Client):


@workflow.defn
class TestUpdateCompletionIsHonoredWhenAfterWorkflowReturn1:
class UpdateCompletionIsHonoredWhenAfterWorkflowReturn1Workflow:
def __init__(self) -> None:
self.workflow_returned = False

Expand All @@ -5867,13 +5867,13 @@ async def test_update_completion_is_honored_when_after_workflow_return_1(
update_id = "my-update"
task_queue = "tq"
wf_handle = await client.start_workflow(
TestUpdateCompletionIsHonoredWhenAfterWorkflowReturn1.run,
UpdateCompletionIsHonoredWhenAfterWorkflowReturn1Workflow.run,
id=f"wf-{uuid.uuid4()}",
task_queue=task_queue,
)
update_result_task = asyncio.create_task(
wf_handle.execute_update(
TestUpdateCompletionIsHonoredWhenAfterWorkflowReturn1.my_update,
UpdateCompletionIsHonoredWhenAfterWorkflowReturn1Workflow.my_update,
id=update_id,
)
)
Expand All @@ -5882,14 +5882,14 @@ async def test_update_completion_is_honored_when_after_workflow_return_1(
async with Worker(
client,
task_queue=task_queue,
workflows=[TestUpdateCompletionIsHonoredWhenAfterWorkflowReturn1],
workflows=[UpdateCompletionIsHonoredWhenAfterWorkflowReturn1Workflow],
):
assert await wf_handle.result() == "workflow-result"
assert await update_result_task == "update-result"


@workflow.defn
class TestUpdateCompletionIsHonoredWhenAfterWorkflowReturnWorkflow2:
class UpdateCompletionIsHonoredWhenAfterWorkflowReturnWorkflow2:
def __init__(self):
self.received_update = False
self.update_result: asyncio.Future[str] = asyncio.Future()
Expand Down Expand Up @@ -5923,15 +5923,15 @@ async def test_update_completion_is_honored_when_after_workflow_return_2(
async with Worker(
client,
task_queue="tq",
workflows=[TestUpdateCompletionIsHonoredWhenAfterWorkflowReturnWorkflow2],
workflows=[UpdateCompletionIsHonoredWhenAfterWorkflowReturnWorkflow2],
) as worker:
handle = await client.start_workflow(
TestUpdateCompletionIsHonoredWhenAfterWorkflowReturnWorkflow2.run,
UpdateCompletionIsHonoredWhenAfterWorkflowReturnWorkflow2.run,
id=f"wf-{uuid.uuid4()}",
task_queue=worker.task_queue,
)
update_result = await handle.execute_update(
TestUpdateCompletionIsHonoredWhenAfterWorkflowReturnWorkflow2.my_update
UpdateCompletionIsHonoredWhenAfterWorkflowReturnWorkflow2.my_update
)
assert update_result == "update-result"
assert await handle.result() == "workflow-result"
Expand Down
Loading