Merge branch 'main' into handle_temporal_builtin_prefixes

mjameswh · web-flow · commit 12062bc335f6 · 2025-07-10T11:00:40.000-04:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -77,6 +77,9 @@ jobs:
           version: '23.x'
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Upgrade Rust to latest stable
+        uses: dtolnay/rust-toolchain@stable
+
       - name: Rust Cargo and Build cache
         if: steps.cached-artifact.outputs.cache-hit != 'true'
         uses: Swatinem/rust-cache@v2
@@ -105,7 +108,7 @@ jobs:
   # Run integration tests.
   # Uses the native binaries built in compile-native-binaries, but build `@temporalio/*` packages locally.
   integration-tests:
-    timeout-minutes: 15
+    timeout-minutes: 20
     needs:
       - compile-native-binaries-debug
     strategy:
diff --git a/.github/workflows/conventions.yml b/.github/workflows/conventions.yml
@@ -40,6 +40,11 @@ jobs:
           version: '23.x'
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Upgrade Rust to latest stable
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          components: clippy
+
       - name: Rust Cargo and Build cache
         uses: Swatinem/rust-cache@v2
         with:
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -75,6 +75,9 @@ jobs:
           version: '23.x'
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Upgrade Rust to latest stable
+        uses: dtolnay/rust-toolchain@stable
+
       # FIXME: Setup volumes so that we can benefit from the cache in the Docker-build scenario.
       #        Or maybe just get rid of the cache entirely if it doesn't have sufficient benefits.
       - name: Rust Cargo and Build cache
diff --git a/.github/workflows/stress.yml b/.github/workflows/stress.yml
@@ -83,6 +83,9 @@ jobs:
           version: '23.x'
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Upgrade Rust to latest stable
+        uses: dtolnay/rust-toolchain@stable
+
       - name: Rust Cargo and Build cache
         uses: Swatinem/rust-cache@v2
         with:
diff --git a/lerna.json b/lerna.json
@@ -1,5 +1,5 @@
 {
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "npmClient": "npm",
   "command": {
     "publish": {
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/activity/package.json b/packages/activity/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/activity",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Temporal.io SDK Activity sub-package",
   "main": "lib/index.js",
   "types": "./lib/index.d.ts",
diff --git a/packages/client/package.json b/packages/client/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/client",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Temporal.io SDK Client sub-package",
   "main": "lib/index.js",
   "types": "./lib/index.d.ts",
diff --git a/packages/cloud/package.json b/packages/cloud/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/cloud",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Temporal.io SDK — Temporal Cloud Client",
   "main": "lib/index.js",
   "types": "./lib/index.d.ts",
diff --git a/packages/common/package.json b/packages/common/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/common",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Common library for code that's used across the Client, Worker, and/or Workflow",
   "main": "lib/index.js",
   "types": "./lib/index.d.ts",
diff --git a/packages/common/src/activity-options.ts b/packages/common/src/activity-options.ts
@@ -120,9 +120,10 @@ export interface ActivityOptions {
    *
    * @default 'COMPATIBLE'
    *
+   * @deprecated In favor of the new Worker Deployment API.
    * @experimental The Worker Versioning API is still being designed. Major changes are expected.
    */
-  versioningIntent?: VersioningIntent;
+  versioningIntent?: VersioningIntent; // eslint-disable-line deprecation/deprecation
 
   /**
    * Priority of this activity
diff --git a/packages/common/src/versioning-intent-enum.ts b/packages/common/src/versioning-intent-enum.ts
@@ -2,11 +2,14 @@ import type { coresdk } from '@temporalio/proto';
 import type { VersioningIntent as VersioningIntentString } from './versioning-intent';
 import { assertNever, checkExtends } from './type-helpers';
 
+/* eslint-disable deprecation/deprecation */
+
 // Avoid importing the proto implementation to reduce workflow bundle size
 // Copied from coresdk.common.VersioningIntent
 /**
  * Protobuf enum representation of {@link VersioningIntentString}.
  *
+ * @deprecated In favor of the new Worker Deployment API.
  * @experimental The Worker Versioning API is still being designed. Major changes are expected.
  */
 export enum VersioningIntent {
diff --git a/packages/common/src/versioning-intent.ts b/packages/common/src/versioning-intent.ts
@@ -11,6 +11,7 @@
  * current worker. The default behavior for starting Workflows is `DEFAULT`. The default behavior for Workflows starting
  * Activities, starting Child Workflows, or Continuing As New is `COMPATIBLE`.
  *
+ * @deprecated In favor of the new Worker Deployment API.
  * @experimental The Worker Versioning API is still being designed. Major changes are expected.
  */
 export type VersioningIntent = 'COMPATIBLE' | 'DEFAULT';
diff --git a/packages/core-bridge/index.js b/packages/core-bridge/index.js
@@ -1,3 +1,4 @@
+const { isPromise } = require('node:util/types');
 const { getPrebuiltPath } = require('./common');
 const typescriptExports = require('./lib/index');
 const { convertFromNamedError } = require('./lib/errors');
@@ -9,7 +10,7 @@ function wrapErrors(fn) {
   return (...args) => {
     try {
       let res = fn(...args);
-      if (res instanceof Promise) {
+      if (isPromise(res)) {
         return res.catch((e) => {
           throw convertFromNamedError(e, false);
         });
@@ -55,7 +56,7 @@ if (process.env.TEMPORAL_TRACE_NATIVE_CALLS?.toLowerCase() === 'true') {
 
         let res = fn(...args);
 
-        if (res instanceof Promise) {
+        if (isPromise(res)) {
           log(callid, `${fnname}() - received promise`);
           return res.then(
             (x) => {
diff --git a/packages/core-bridge/package.json b/packages/core-bridge/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/core-bridge",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Temporal.io SDK Core<>Node bridge",
   "main": "index.js",
   "types": "lib/index.d.ts",
diff --git a/packages/core-bridge/sdk-core b/packages/core-bridge/sdk-core
@@ -1 +1 @@
-Subproject commit 1a3b41b3c4ec5d800c84995748e9f16a67a9d4d9
+Subproject commit 24a3c23a6dc8842fddb5be3a52a534b863a01a7c
diff --git a/packages/core-bridge/src/metrics.rs b/packages/core-bridge/src/metrics.rs
@@ -21,7 +21,7 @@ use crate::helpers::{
     BridgeError, BridgeResult, JsonString, MutableFinalize, OpaqueInboundHandle,
     OpaqueOutboundHandle,
 };
-use crate::runtime::*;
+use crate::runtime::Runtime;
 
 pub fn init(cx: &mut neon::prelude::ModuleContext) -> neon::prelude::NeonResult<()> {
     cx.export_function("newMetricCounter", new_metric_counter)?;
@@ -91,10 +91,10 @@ pub enum MetricValue {
 impl From<MetricValue> for CoreMetricValue {
     fn from(value: MetricValue) -> Self {
         match value {
-            MetricValue::Int(i) => CoreMetricValue::Int(i),
-            MetricValue::Float(f) => CoreMetricValue::Float(f),
-            MetricValue::Bool(b) => CoreMetricValue::Bool(b),
-            MetricValue::String(s) => CoreMetricValue::String(s),
+            MetricValue::Int(i) => Self::Int(i),
+            MetricValue::Float(f) => Self::Float(f),
+            MetricValue::Bool(b) => Self::Bool(b),
+            MetricValue::String(s) => Self::String(s),
         }
     }
 }
diff --git a/packages/create-project/package.json b/packages/create-project/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/create",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Create a Temporal project from template",
   "main": "cli.js",
   "bin": "cli.js",
diff --git a/packages/interceptors-opentelemetry/package.json b/packages/interceptors-opentelemetry/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/interceptors-opentelemetry",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Temporal.io SDK interceptors bundle for tracing with opentelemetry",
   "main": "lib/index.js",
   "types": "./lib/index.d.ts",
diff --git a/packages/nyc-test-coverage/package.json b/packages/nyc-test-coverage/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/nyc-test-coverage",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Temporal.io SDK code coverage integration",
   "keywords": [
     "temporal",
diff --git a/packages/proto/package.json b/packages/proto/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/proto",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Temporal.io SDK compiled protobuf definitions",
   "main": "protos/index.js",
   "types": "protos/index.d.ts",
diff --git a/packages/test/package.json b/packages/test/package.json
@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "@temporalio/test",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Temporal.io SDK Tests",
   "scripts": {
     "build": "npm-run-all build:protos build:ts",
diff --git a/packages/test/src/test-bridge.ts b/packages/test/src/test-bridge.ts
@@ -266,7 +266,7 @@ const GenericConfigs = {
       tuner: {
         workflowTaskSlotSupplier: {
           type: 'fixed-size',
-          numSlots: 1,
+          numSlots: 2,
         },
         activityTaskSlotSupplier: {
           type: 'fixed-size',
@@ -280,7 +280,7 @@ const GenericConfigs = {
       nonStickyToStickyPollRatio: 0.5,
       workflowTaskPollerBehavior: {
         type: 'simple-maximum',
-        maximum: 1,
+        maximum: 2,
       },
       activityTaskPollerBehavior: {
         type: 'autoscaling',
diff --git a/packages/testing/package.json b/packages/testing/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/testing",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Temporal.io SDK Testing sub-package",
   "main": "lib/index.js",
   "types": "./lib/index.d.ts",
diff --git a/packages/worker/package.json b/packages/worker/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/worker",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Temporal.io SDK Worker sub-package",
   "main": "lib/index.js",
   "types": "./lib/index.d.ts",
diff --git a/packages/workflow/package.json b/packages/workflow/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@temporalio/workflow",
-  "version": "1.12.0-rc.0",
+  "version": "1.12.1",
   "description": "Temporal.io SDK Workflow sub-package",
   "keywords": [
     "temporal",
diff --git a/packages/workflow/src/interfaces.ts b/packages/workflow/src/interfaces.ts
diff --git a/packages/workflow/src/workflow.ts b/packages/workflow/src/workflow.ts

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "version": "1.12.0-rc.0",`
	`2`	`+ "version": "1.12.1",`
`3`	`3`	`"npmClient": "npm",`
`4`	`4`	`"command": {`
`5`	`5`	`"publish": {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@temporalio/activity",`
`3`		`- "version": "1.12.0-rc.0",`
	`3`	`+ "version": "1.12.1",`
`4`	`4`	`"description": "Temporal.io SDK Activity sub-package",`
`5`	`5`	`"main": "lib/index.js",`
`6`	`6`	`"types": "./lib/index.d.ts",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@temporalio/client",`
`3`		`- "version": "1.12.0-rc.0",`
	`3`	`+ "version": "1.12.1",`
`4`	`4`	`"description": "Temporal.io SDK Client sub-package",`
`5`	`5`	`"main": "lib/index.js",`
`6`	`6`	`"types": "./lib/index.d.ts",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@temporalio/cloud",`
`3`		`- "version": "1.12.0-rc.0",`
	`3`	`+ "version": "1.12.1",`
`4`	`4`	`"description": "Temporal.io SDK — Temporal Cloud Client",`
`5`	`5`	`"main": "lib/index.js",`
`6`	`6`	`"types": "./lib/index.d.ts",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@temporalio/common",`
`3`		`- "version": "1.12.0-rc.0",`
	`3`	`+ "version": "1.12.1",`
`4`	`4`	`"description": "Common library for code that's used across the Client, Worker, and/or Workflow",`
`5`	`5`	`"main": "lib/index.js",`
`6`	`6`	`"types": "./lib/index.d.ts",`