Completed self review

Author: mjameswh

packages/test/src/test-sinks.ts

@@ -2,7 +2,7 @@
 import test from 'ava';
 import { v4 as uuid4 } from 'uuid';
 import { Connection, WorkflowClient } from '@temporalio/client';
-import { DefaultLogger, InjectedSinks, Runtime, WorkerOptions, LogEntry } from '@temporalio/worker';
+import { DefaultLogger, InjectedSinks, Runtime, WorkerOptions, LogEntry, NativeConnection } from '@temporalio/worker';
 import { SearchAttributes, WorkflowInfo } from '@temporalio/workflow';
 import { UnsafeWorkflowInfo } from '@temporalio/workflow/lib/interfaces';
 import { SdkComponent, TypedSearchAttributes } from '@temporalio/common';
@@ -21,6 +21,7 @@ class DependencyError extends Error {
 
 if (RUN_INTEGRATION_TESTS) {
   const recordedLogs: { [workflowId: string]: LogEntry[] } = {};
+  let nativeConnection: NativeConnection;
 
   test.before(async (_) => {
     await registerDefaultCustomSearchAttributes(await Connection.connect({}));
@@ -31,6 +32,17 @@ if (RUN_INTEGRATION_TESTS) {
         recordedLogs[workflowId].push(entry);
       }),
     });
+
+    // FIXME(JWH): At some point, tests in this file ends up creating a situation where we no longer have any
+    // native resource tracked by the lang side Runtime object, so the lang Runtime tries to shutdown itself,
+    // but in the mean time, another test tries to create another resource. which results in a rust side
+    // finalization error. Holding on to a nativeConnection object avoids that situation. That's a dirty hack.
+    // Proper fix will be implemented in a distinct PR.
+    nativeConnection = await NativeConnection.connect({});
+  });
+
+  test.after.always(async () => {
+    await nativeConnection.close();
   });
 
   test('Worker injects sinks', async (t) => {

packages/worker/src/runtime.ts

@@ -278,6 +278,7 @@ export class Runtime {
       if (Runtime._instance === this) delete Runtime._instance;
       (this as any).metricMeter = noopMetricMeter;
       this.teardownShutdownHook();
+      // FIXME(JWH): I think we no longer need this, but will have to thoroughly validate.
       native.runtimeShutdown(this.native);
       this.flushLogs();
     } finally {

packages/workflow/src/metrics.ts

@@ -183,8 +183,7 @@ export const metricMeter: MetricMeter = MetricMeterWithComposedTags.compose(
 
     const info = activator.info;
     return getMetricTags({
-      namespace: info.namespace,
-      taskQueue: info.taskQueue,
+      // namespace and taskQueue will be added by the Worker
       workflowType: info.workflowType,
     });
   },