Remove tests using Client backed by native connection

Author: mjameswh

packages/test/src/test-native-connection-headers.ts

@@ -1,6 +1,5 @@
-import util from 'node:util';
-import path from 'node:path';
-import assert from 'node:assert';
+import * as util from 'node:util';
+import * as path from 'node:path';
 import test from 'ava';
 import { Subject, firstValueFrom, skip } from 'rxjs';
 import * as grpc from '@grpc/grpc-js';
@@ -9,19 +8,6 @@ import { NativeConnection } from '@temporalio/worker';
 import { temporal } from '@temporalio/proto';
 import { Worker } from './helpers';
 
-const workflowServicePackageDefinition = protoLoader.loadSync(
-  path.resolve(
-    __dirname,
-    '../../core-bridge/sdk-core/sdk-core-protos/protos/api_upstream/temporal/api/workflowservice/v1/service.proto'
-  ),
-  { includeDirs: [path.resolve(__dirname, '../../core-bridge/sdk-core/sdk-core-protos/protos/api_upstream')] }
-);
-const workflowServiceProtoDescriptor = grpc.loadPackageDefinition(workflowServicePackageDefinition) as any;
-
-async function bindLocalhost(server: grpc.Server): Promise<number> {
-  return await util.promisify(server.bindAsync.bind(server))('127.0.0.1:0', grpc.ServerCredentials.createInsecure());
-}
-
 test('NativeConnection passes headers provided in options', async (t) => {
   const packageDefinition = protoLoader.loadSync(
     path.resolve(
@@ -103,44 +89,3 @@ test('NativeConnection passes headers provided in options', async (t) => {
   });
   await Promise.all([firstValueFrom(newValuesSubject.pipe(skip(1))).then(() => worker.shutdown()), worker.run()]);
 });
-
-test('apiKey sets temporal-namespace header appropriately', async (t) => {
-  let getSystemInfoHeaders: grpc.Metadata = new grpc.Metadata();
-  let startWorkflowExecutionHeaders: grpc.Metadata = new grpc.Metadata();
-
-  const server = new grpc.Server();
-  server.addService(workflowServiceProtoDescriptor.temporal.api.workflowservice.v1.WorkflowService.service, {
-    getSystemInfo(
-      call: grpc.ServerUnaryCall<
-        temporal.api.workflowservice.v1.IGetSystemInfoRequest,
-        temporal.api.workflowservice.v1.IGetSystemInfoResponse
-      >,
-      callback: grpc.sendUnaryData<temporal.api.workflowservice.v1.IGetSystemInfoResponse>
-    ) {
-      getSystemInfoHeaders = call.metadata.clone();
-      callback(null, {});
-    },
-    startWorkflowExecution(call: grpc.ServerUnaryCall<any, any>, callback: grpc.sendUnaryData<any>) {
-      startWorkflowExecutionHeaders = call.metadata.clone();
-      callback(null, {});
-    },
-  });
-  const port = await bindLocalhost(server);
-  const conn = await NativeConnection.connect({
-    address: `127.0.0.1:${port}`,
-    metadata: { staticKey: 'set' },
-    apiKey: 'test-token',
-  });
-
-  await conn.workflowService.startWorkflowExecution({ namespace: 'test-namespace' });
-
-  assert(getSystemInfoHeaders !== undefined);
-  t.deepEqual(getSystemInfoHeaders.get('temporal-namespace'), []);
-  t.deepEqual(getSystemInfoHeaders.get('authorization'), ['Bearer test-token']);
-  t.deepEqual(getSystemInfoHeaders.get('staticKey'), ['set']);
-
-  assert(startWorkflowExecutionHeaders);
-  t.deepEqual(startWorkflowExecutionHeaders.get('temporal-namespace'), ['test-namespace']);
-  t.deepEqual(startWorkflowExecutionHeaders.get('authorization'), ['Bearer test-token']);
-  t.deepEqual(startWorkflowExecutionHeaders.get('staticKey'), ['set']);
-});

packages/test/src/test-temporal-cloud.ts

@@ -36,8 +36,6 @@ test('Can connect to Temporal Cloud using mTLS', async (t) => {
       },
     },
   });
-  const nativeClient = new Client({ connection: nativeConnection, namespace });
-
   const taskQueue = `test-temporal-cloud-mtls-${randomUUID()}`;
   const worker = await Worker.create({
     namespace,
@@ -46,21 +44,14 @@ test('Can connect to Temporal Cloud using mTLS', async (t) => {
     taskQueue,
   });
 
-  const [res1, res2] = await worker.runUntil(async () => {
-    return Promise.all([
-      client.workflow.execute(workflows.successString, {
-        workflowId: randomUUID(),
-        taskQueue,
-      }),
-      nativeClient.workflow.execute(workflows.successString, {
-        workflowId: randomUUID(),
-        taskQueue,
-      }),
-    ]);
+  const res = await worker.runUntil(async () => {
+    return await client.workflow.execute(workflows.successString, {
+      workflowId: randomUUID(),
+      taskQueue,
+    });
   });
 
-  t.is(res1, 'success');
-  t.is(res2, 'success');
+  t.is(res, 'success');
 });
 
 test('Can connect to Temporal Cloud using API Keys', async (t) => {
@@ -85,8 +76,6 @@ test('Can connect to Temporal Cloud using API Keys', async (t) => {
     apiKey,
     tls: true,
   });
-  const nativeClient = new Client({ connection: nativeConnection, namespace });
-
   const taskQueue = `test-temporal-cloud-api-key-${randomUUID()}`;
   const worker = await Worker.create({
     namespace,
@@ -95,21 +84,14 @@ test('Can connect to Temporal Cloud using API Keys', async (t) => {
     taskQueue,
   });
 
-  const [res1, res2] = await worker.runUntil(async () => {
-    return Promise.all([
-      client.workflow.execute(workflows.successString, {
-        workflowId: randomUUID(),
-        taskQueue,
-      }),
-      nativeClient.workflow.execute(workflows.successString, {
-        workflowId: randomUUID(),
-        taskQueue,
-      }),
-    ]);
+  const res = await worker.runUntil(async () => {
+    return await client.workflow.execute(workflows.successString, {
+      workflowId: randomUUID(),
+      taskQueue,
+    });
   });
 
-  t.is(res1, 'success');
-  t.is(res2, 'success');
+  t.is(res, 'success');
 });
 
 test('Can create connection to Temporal Cloud Operation service', async (t) => {