TLS CI test failing - fixed

Author: mjameswh

.github/workflows/ci.yml

@@ -206,16 +206,7 @@ jobs:
             --headless &> ./devserver.log &
 
       - name: Run Tests
-        run: |
-          mkdir /tmp/temporal-certs &&
-          echo "$TEMPORAL_CLOUD_MTLS_TEST_CLIENT_CERT" > /tmp/temporal-certs/client.pem &&
-          echo "$TEMPORAL_CLOUD_MTLS_TEST_CLIENT_KEY" > /tmp/temporal-certs/client.key &&
-          wc /tmp/temporal-certs/client.pem /tmp/temporal-certs/client.key
-
-          echo $TEMPORAL_CLOUD_MTLS_TEST_TARGET_HOST
-          echo $TEMPORAL_CLOUD_MTLS_TEST_NAMESPACE
-
-          npm run test
+        run: npm run test
         env:
           RUN_INTEGRATION_TESTS: true
           REUSE_V8_CONTEXT: ${{ matrix.reuse-v8-context }}
@@ -263,6 +254,9 @@ jobs:
           TEMPORAL_CLIENT_KEY: ${{ secrets.TEMPORAL_CLIENT_KEY }}
           TEMPORAL_TASK_QUEUE: ${{ format('tssdk-ci-{0}-{1}-sample-hello-world-mtls-{2}-{3}', matrix.platform, matrix.node, github.run_id, github.run_attempt) }}
 
+          TEMPORAL_CLIENT_CERT_PATH: ${{ steps.tmp-dir.outputs.dir }}/certs/client.pem
+          TEMPORAL_CLIENT_KEY_PATH: ${{ steps.tmp-dir.outputs.dir }}/certs/client.key
+
       - name: Destroy certs dir
         if: always()
         run: rm -rf ${{ steps.tmp-dir.outputs.dir }}/certs

.github/workflows/release.yml

@@ -317,23 +317,24 @@ jobs:
         if: matrix.server == 'cli'
 
       - name: Test run a workflow (cloud)
+        if: matrix.server == 'cloud'
         run: |
           # The required environment variables must be present for releases (this must be run from the official repo)
           node scripts/create-certs-dir.js ${{ steps.tmp-dir.outputs.dir }}/certs
           node scripts/test-example.js --work-dir "${{ runner.temp }}/example"
-        if: matrix.server == 'cloud'
+        shell: bash
         env:
           # These env vars are used by the hello-world-mtls sample
           TEMPORAL_ADDRESS: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}.tmprl.cloud:7233
           TEMPORAL_NAMESPACE: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}
-          TEMPORAL_CLIENT_CERT: ${{ secrets.TEMPORAL_CLIENT_CERT }}
-          TEMPORAL_CLIENT_KEY: ${{ secrets.TEMPORAL_CLIENT_KEY }}
+          TEMPORAL_CLIENT_CERT_PATH: ${{ runner.temp }}/certs/client.pem
+          TEMPORAL_CLIENT_KEY_PATH: ${{ runner.temp }}/certs/client.key
           TEMPORAL_TASK_QUEUE: ${{ format('tssdk-ci-{0}-{1}-sample-hello-world-mtls-{2}-{3}', matrix.platform, matrix.node, github.run_id, github.run_attempt) }}
 
       - name: Destroy certs dir
         if: always()
         shell: bash
-        run: rm -rf ${{ steps.tmp-dir.outputs.dir }}/certs
+        run: rm -rf ${{ runner.temp }}/certs
         continue-on-error: true
 
   conventions:

packages/test/src/test-temporal-cloud.ts

@@ -16,10 +16,6 @@ test('Can connect to Temporal Cloud using mTLS', async (t) => {
     return;
   }
 
-  console.log(
-    `Connecting to Temporal Cloud with mTLS: ${address}__${namespace}__${clientCert?.length}__${clientKey?.length}`
-  );
-
   const connection = await Connection.connect({
     address,
     tls: {
@@ -77,8 +73,6 @@ test('Can connect to Temporal Cloud using API Keys', async (t) => {
     return;
   }
 
-  console.log(`Connecting to Temporal Cloud with API Key: ${address}__${namespace}__${apiKey?.length}`);
-
   const connection = await Connection.connect({
     address,
     apiKey,