Skip to content

Commit dc1312b

Browse files
committed
Debugging somes bugs
1 parent 577a565 commit dc1312b

File tree

3 files changed

+101
-452
lines changed

3 files changed

+101
-452
lines changed

.github/workflows/ci.yml

Lines changed: 101 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -30,26 +30,26 @@ jobs:
3030
fail-fast: true
3131
matrix:
3232
include:
33-
- platform: linux-x64
34-
runner: ubuntu-latest
35-
target: x86_64-unknown-linux-gnu
36-
out-file: libtemporal_sdk_typescript_bridge.so
33+
# - platform: linux-x64
34+
# runner: ubuntu-latest
35+
# target: x86_64-unknown-linux-gnu
36+
# out-file: libtemporal_sdk_typescript_bridge.so
3737
- platform: linux-arm
3838
runner: ubuntu-24.04-arm64-2-core
3939
target: aarch64-unknown-linux-gnu
4040
out-file: libtemporal_sdk_typescript_bridge.so
41-
- platform: macos-x64
42-
runner: macos-13
43-
target: x86_64-apple-darwin
44-
out-file: libtemporal_sdk_typescript_bridge.dylib
45-
- platform: macos-arm
46-
runner: macos-14
47-
target: aarch64-apple-darwin
48-
out-file: libtemporal_sdk_typescript_bridge.dylib
49-
- platform: windows-x64
50-
runner: windows-latest
51-
target: x86_64-pc-windows-msvc
52-
out-file: temporal_sdk_typescript_bridge.dll
41+
# - platform: macos-x64
42+
# runner: macos-13
43+
# target: x86_64-apple-darwin
44+
# out-file: libtemporal_sdk_typescript_bridge.dylib
45+
# - platform: macos-arm
46+
# runner: macos-14
47+
# target: aarch64-apple-darwin
48+
# out-file: libtemporal_sdk_typescript_bridge.dylib
49+
# - platform: windows-x64
50+
# runner: windows-latest
51+
# target: x86_64-pc-windows-msvc
52+
# out-file: temporal_sdk_typescript_bridge.dll
5353
name: Compile Native Binaries (${{ matrix.platform }})
5454
runs-on: ${{ matrix.runner }}
5555
defaults:
@@ -115,26 +115,26 @@ jobs:
115115
strategy:
116116
fail-fast: false
117117
matrix:
118-
node: [16, 22] # Min and max supported Node versions
119-
platform: [linux-x64, linux-arm, macos-x64, macos-arm, windows-x64]
118+
node: [22] # Min and max supported Node versions
119+
platform: [linux-arm]
120120
server: [cli] # FIXME: Add 'cloud'
121121
include:
122-
- platform: linux-x64
123-
runner: ubuntu-latest
124-
# For efficiency, we only run non-reuse-v8-context tests on this platform
125-
reuse-v8-context: false
122+
# - platform: linux-x64
123+
# runner: ubuntu-latest
124+
# # For efficiency, we only run non-reuse-v8-context tests on this platform
125+
# reuse-v8-context: false
126126
- platform: linux-arm
127127
runner: ubuntu-24.04-arm64-2-core
128128
reuse-v8-context: true
129-
- platform: macos-x64
130-
runner: macos-13
131-
reuse-v8-context: true
132-
- platform: macos-arm
133-
runner: macos-14
134-
reuse-v8-context: true
135-
- platform: windows-x64
136-
runner: windows-latest
137-
reuse-v8-context: true
129+
# - platform: macos-x64
130+
# runner: macos-13
131+
# reuse-v8-context: true
132+
# - platform: macos-arm
133+
# runner: macos-14
134+
# reuse-v8-context: true
135+
# - platform: windows-x64
136+
# runner: windows-latest
137+
# reuse-v8-context: true
138138
runs-on: ${{ matrix.runner }}
139139
name: Run Integration Tests (${{ matrix.platform }}, Node ${{ matrix.node }}, Reuse V8 Context ${{ matrix.reuse-v8-context }})
140140
steps:
@@ -181,6 +181,7 @@ jobs:
181181

182182
- name: Run Temporal CLI
183183
if: matrix.server == 'cli'
184+
shell: bash
184185
run: |
185186
temporal server start-dev \
186187
--db-filename temporal.sqlite \
@@ -193,24 +194,41 @@ jobs:
193194
run: node scripts/create-certs-dir.js "${{ runner.temp }}/certs"
194195
if: ${{ vars.TEMPORAL_CLIENT_NAMESPACE != '' }}
195196

196-
- name: Run Tests
197-
run: npm test
198-
env:
199-
RUN_INTEGRATION_TESTS: true
200-
REUSE_V8_CONTEXT: ${{ matrix.reuse-v8-context }}
197+
# - name: Run Tests
198+
# run: npm test
199+
# env:
200+
# RUN_INTEGRATION_TESTS: true
201+
# REUSE_V8_CONTEXT: ${{ matrix.reuse-v8-context }}
201202

202-
# Cloud Tests will be skipped if TEMPORAL_CLIENT_CLOUD_API_KEY is left empty
203-
TEMPORAL_CLOUD_SAAS_ADDRESS: ${{ vars.TEMPORAL_CLOUD_SAAS_ADDRESS || 'saas-api.tmprl.cloud:443' }}
204-
TEMPORAL_CLIENT_CLOUD_API_KEY: ${{ secrets.TEMPORAL_CLIENT_CLOUD_API_KEY }}
205-
TEMPORAL_CLIENT_CLOUD_API_VERSION: 2024-05-13-00
206-
TEMPORAL_CLIENT_CLOUD_NAMESPACE: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}
203+
# # Cloud Tests will be skipped if TEMPORAL_CLIENT_CLOUD_API_KEY is left empty
204+
# TEMPORAL_CLOUD_SAAS_ADDRESS: ${{ vars.TEMPORAL_CLOUD_SAAS_ADDRESS || 'saas-api.tmprl.cloud:443' }}
205+
# TEMPORAL_CLIENT_CLOUD_API_KEY: ${{ secrets.TEMPORAL_CLIENT_CLOUD_API_KEY }}
206+
# TEMPORAL_CLIENT_CLOUD_API_VERSION: 2024-05-13-00
207+
# TEMPORAL_CLIENT_CLOUD_NAMESPACE: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}
207208

208209
- name: Publish to Verdaccio
209210
run: node scripts/publish-to-verdaccio.js --registry-dir ./tmp/registry
210211

211212
# FIXME: Move samples tests to a custom activity
212213
# Sample 1: hello-world to local server
213214
- name: Instantiate sample project using verdaccio artifacts - Hello World
215+
shell: bash
216+
# Note: here, `npx create` fails on windows if shell is bash.
217+
run: |
218+
node scripts/init-from-verdaccio.js --registry-dir ./tmp/registry --sample https://github.com/temporalio/samples-typescript/tree/main/hello-world --target-dir ${{ runner.temp }}/sample-hello-world
219+
220+
# FIXME: Move samples tests to a custom activity
221+
# Sample 1: hello-world to local server
222+
- name: Instantiate sample project using verdaccio artifacts - Hello World
223+
shell: bash
224+
# Note: here, `npx create` fails on windows if shell is bash.
225+
run: |
226+
node scripts/test-example.js --work-dir "${{ runner.temp }}/sample-hello-world"
227+
228+
# FIXME: Move samples tests to a custom activity
229+
# Sample 1: hello-world to local server
230+
- name: Instantiate sample project using verdaccio artifacts - Hello World
231+
shell: bash
214232
# Note: here, `npx create` fails on windows if shell is bash.
215233
run: |
216234
echo "111"
@@ -263,45 +281,45 @@ jobs:
263281
name: integration-tests-${{ matrix.platform }}-node${{ matrix.node }}-${{ matrix.server }}-${{ matrix.reuse-v8-context && 'reuse' || 'noreuse' }}-devserver-logs
264282
path: /tmp/devserver.log
265283

266-
conventions:
267-
name: Lint and Prune
268-
uses: ./.github/workflows/conventions.yml
269-
270-
# Runs the features repo tests with this repo's current SDK code
271-
# FIXME: Update this job to reuse native build artifacts from compile-native-binaries
272-
features-tests:
273-
name: Features Tests
274-
uses: temporalio/features/.github/workflows/typescript.yaml@main
275-
with:
276-
typescript-repo-path: ${{github.event.pull_request.head.repo.full_name}}
277-
version: ${{github.event.pull_request.head.ref}}
278-
version-is-repo-ref: true
279-
features-repo-ref: sdk-1403-ts-startUpdate-require-wait-stage
280-
281-
stress-tests-no-reuse-context:
282-
name: Stress Tests (No Reuse V8 Context)
283-
# FIXME: Update this job to reuse native build artifacts from compile-native-binaries
284-
uses: ./.github/workflows/stress.yml
285-
with:
286-
test-type: ci-stress
287-
test-timeout-minutes: 20
288-
reuse-v8-context: false
289-
290-
stress-tests-reuse-context:
291-
name: Stress Tests (Reuse V8 Context)
292-
# FIXME: Update this job to reuse native build artifacts from compile-native-binaries
293-
uses: ./.github/workflows/stress.yml
294-
with:
295-
test-type: ci-stress
296-
test-timeout-minutes: 20
297-
reuse-v8-context: true
298-
299-
docs:
300-
name: Build Docs
301-
uses: ./.github/workflows/docs.yml
302-
with:
303-
# Can't publish from forks, as secrets won't be available
304-
publish_target: ${{ vars.IS_TEMPORALIO_SDK_TYPESCRIPT_REPO == 'true' && 'draft' || '' }}
305-
secrets:
306-
ALGOLIA_API_KEY: ${{ secrets.ALGOLIA_API_KEY }}
307-
VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }}
284+
# conventions:
285+
# name: Lint and Prune
286+
# uses: ./.github/workflows/conventions.yml
287+
288+
# # Runs the features repo tests with this repo's current SDK code
289+
# # FIXME: Update this job to reuse native build artifacts from compile-native-binaries
290+
# features-tests:
291+
# name: Features Tests
292+
# uses: temporalio/features/.github/workflows/typescript.yaml@main
293+
# with:
294+
# typescript-repo-path: ${{github.event.pull_request.head.repo.full_name}}
295+
# version: ${{github.event.pull_request.head.ref}}
296+
# version-is-repo-ref: true
297+
# features-repo-ref: sdk-1403-ts-startUpdate-require-wait-stage
298+
299+
# stress-tests-no-reuse-context:
300+
# name: Stress Tests (No Reuse V8 Context)
301+
# # FIXME: Update this job to reuse native build artifacts from compile-native-binaries
302+
# uses: ./.github/workflows/stress.yml
303+
# with:
304+
# test-type: ci-stress
305+
# test-timeout-minutes: 20
306+
# reuse-v8-context: false
307+
308+
# stress-tests-reuse-context:
309+
# name: Stress Tests (Reuse V8 Context)
310+
# # FIXME: Update this job to reuse native build artifacts from compile-native-binaries
311+
# uses: ./.github/workflows/stress.yml
312+
# with:
313+
# test-type: ci-stress
314+
# test-timeout-minutes: 20
315+
# reuse-v8-context: true
316+
317+
# docs:
318+
# name: Build Docs
319+
# uses: ./.github/workflows/docs.yml
320+
# with:
321+
# # Can't publish from forks, as secrets won't be available
322+
# publish_target: ${{ vars.IS_TEMPORALIO_SDK_TYPESCRIPT_REPO == 'true' && 'draft' || '' }}
323+
# secrets:
324+
# ALGOLIA_API_KEY: ${{ secrets.ALGOLIA_API_KEY }}
325+
# VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }}

.github/workflows/omes.yml

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)