address review suggestions

Author: THardy98

packages/activity/src/index.ts

@@ -77,11 +77,11 @@ import {
   LogMetadata,
   MetricMeter,
   Priority,
-  ActivityCancellationDetailsHolder,
   ActivityCancellationDetails,
 } from '@temporalio/common';
 import { msToNumber } from '@temporalio/common/lib/time';
 import { SymbolBasedInstanceOfError } from '@temporalio/common/lib/type-helpers';
+import { ActivityCancellationDetailsHolder } from '@temporalio/common/lib/activity-cancellation-details';
 
 export {
   ActivityFunction,
@@ -364,7 +364,13 @@ export class Context {
     return Promise.race([this.cancelled.finally(() => clearTimeout(handle)), timer]);
   };
 
-  public cancellationDetails(): ActivityCancellationDetails | undefined {
+  /**
+   * Return the cancellation details for this activity, if any.
+   * @returns an object with boolean properties that describes the reason for cancellation, or undefined if not cancelled.
+   *
+   * @experimental Activity cancellation details include usage of experimental features such as activity pause, and may be subject to change.
+   */
+  public get cancellationDetails(): ActivityCancellationDetails | undefined {
     return this._cancellationDetails.details;
   }
 }
@@ -448,10 +454,13 @@ export function cancelled(): Promise<never> {
 }
 
 /**
- * Returns the cancellation details for this activity, if any.
+ * Return the cancellation details for this activity, if any.
+ * @returns an object with boolean properties that describes the reason for cancellation, or undefined if not cancelled.
+ *
+ * @experimental Activity cancellation details include usage of experimental features such as activity pause, and may be subject to change.
  */
 export function cancellationDetails(): ActivityCancellationDetails | undefined {
-  return Context.current().cancellationDetails();
+  return Context.current().cancellationDetails;
 }
 
 /**

packages/common/src/index.ts

@@ -8,7 +8,7 @@ import * as encoding from './encoding';
 import * as helpers from './type-helpers';
 
 export * from './activity-options';
-export * from './activity-cancellation-details';
+export { ActivityCancellationDetailsOptions, ActivityCancellationDetails } from './activity-cancellation-details';
 export * from './converter/data-converter';
 export * from './converter/failure-converter';
 export * from './converter/payload-codec';

packages/worker/src/activity.ts

@@ -2,7 +2,6 @@ import 'abort-controller/polyfill'; // eslint-disable-line import/no-unassigned-
 import { asyncLocalStorage, CompleteAsyncError, Context, Info } from '@temporalio/activity';
 import {
   ActivityCancellationDetails,
-  ActivityCancellationDetailsHolder,
   ActivityFunction,
   ApplicationFailure,
   ApplicationFailureCategory,
@@ -21,6 +20,7 @@ import { isAbortError } from '@temporalio/common/lib/type-helpers';
 import { Logger, LoggerWithComposedMetadata } from '@temporalio/common/lib/logger';
 import { MetricMeterWithComposedTags } from '@temporalio/common/lib/metrics';
 import { coresdk } from '@temporalio/proto';
+import { ActivityCancellationDetailsHolder } from '@temporalio/common/lib/activity-cancellation-details';
 import {
   ActivityExecuteInput,
   ActivityInboundCallsInterceptor,
@@ -144,7 +144,7 @@ export class Activity {
         (error instanceof CancelledFailure || isAbortError(error)) &&
         this.context.cancellationSignal.aborted
       ) {
-        if (this.context.cancellationDetails()?.paused) {
+        if (this.context.cancellationDetails?.paused) {
           this.workerLogger.debug('Activity paused', { durationMs });
         } else {
           this.workerLogger.debug('Activity completed as cancelled', { durationMs });
@@ -187,7 +187,7 @@ export class Activity {
           // Either a CancelledFailure that we threw or AbortError from AbortController
           if (err instanceof CancelledFailure) {
             // If cancel due to activity pause, emit an application failure for the pause.
-            if (this.context.cancellationDetails()?.paused) {
+            if (this.context.cancellationDetails?.paused) {
               return {
                 failed: {
                   failure: await encodeErrorToFailure(