Skip to content

Commit fdd47d5

Browse files
committed
Only do non-reuse-v8-context integration tests on one platform
1 parent 015c34b commit fdd47d5

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ jobs:
182182

183183
# Run integration tests.
184184
# Uses the native binaries built in compile-native-binaries, but build `@temporalio/*` packages locally.
185+
# FIXME: Move ReuseV8Context vs non-ReuseV8Context out of the matrix, to the test script
185186
integration-tests:
186187
timeout-minutes: 10
187188
needs:
@@ -192,19 +193,23 @@ jobs:
192193
node: [16, 22] # Min and max supported Node versions
193194
platform: [linux-x64, linux-arm, macos-x64, macos-arm, windows-x64]
194195
server: [cli] # FIXME: Add 'cloud'
195-
reuse-v8-context: [true] # Only test non-reuse-v8-context on linux-x64
196196
include:
197197
- platform: linux-x64
198198
runner: ubuntu-latest-4-cores
199-
reuse-v8-context: [true, false]
199+
# For efficiency, we only run non-reuse-v8-context tests on this platform
200+
reuse-v8-context: false
200201
- platform: linux-arm
201202
runner: ubuntu-24.04-arm64-2-core
203+
reuse-v8-context: true
202204
- platform: macos-x64
203205
runner: macos-13
206+
reuse-v8-context: true
204207
- platform: macos-arm
205208
runner: macos-14
209+
reuse-v8-context: true
206210
- platform: windows-x64
207211
runner: windows-latest
212+
reuse-v8-context: true
208213
runs-on: ${{ matrix.runner }}
209214
name: Run Integration Tests (${{ matrix.platform }}, Node ${{ matrix.node }}, Reuse V8 Context ${{ matrix.reuse-v8-context }})
210215
defaults:
@@ -290,7 +295,7 @@ jobs:
290295

291296
# FIXME: Use a single job instance to run all samples for a given platform
292297
# FIXME: Merge sample testing into integration-tests
293-
# FIXME:
298+
# FIXME: Once merged in integration-tests, remove the matrix and use a single job instance
294299
# Tests that npm init @temporalio results in a working worker and client
295300
test-npm-init:
296301
needs: build-packages

0 commit comments

Comments
 (0)