Skip to content

[Bug] Remove peer dependencies from @temporalio/interceptors-opentelemetry #1785

@TastyPi

Description

@TastyPi

What are you really trying to do?

Depend on @temporalio/interceptors-opentelemetry in my app that uses @temporalio/client.

Describe the bug

When I run yarn install I get the following messages:

➤ YN0002: │ my-package doesn't provide @temporalio/activity (p98051a), requested by @temporalio/interceptors-opentelemetry.
➤ YN0002: │ my-package doesn't provide @temporalio/common (pd7eebd), requested by @temporalio/interceptors-opentelemetry.
➤ YN0002: │ my-package doesn't provide @temporalio/worker (p41c8fb), requested by @temporalio/interceptors-opentelemetry.
➤ YN0002: │ my-package doesn't provide @temporalio/workflow (pd62775), requested by @temporalio/interceptors-opentelemetry.

YN0002 is caused by missing peer dependencies. To clear these messages, I would have to add dependencies on those other libraries. Except it does not make sense for my app that only uses @temporalio/client to depend on those other libraries (except maybe @temporalio/common).

The proper fix would be to not have these peer dependencies, or split @temporalio/interceptors-opentelemetry into separate packages for clients/workflows/activities.

Minimal Reproduction

Create an app that depends on @temporalio/interceptors-opentelemetry with Yarn.

Environment/Versions

  • OS and processor: Linux
  • Temporal SDK Version: 1.13.0
  • Yarn version: 4.9.4

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions