chore: Tune up Temporal Dev Server db config in stress tests #1572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjameswh
changed the title
Quinn-With-Two-Ns
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Re-enabled file-based persistence on dev server for stress tests. This should hopefully resolve the consistent failure of nightly stress tests we have been observing since the workflow was modified to use CLI rather a Docker-based server.
This change had been previously attempted in fix(ci): Enable file-based persistence on dev server for stress tests #1480, then reverted in fix(ci): Revert enabling file-based persistence on dev server for stress tests #1497 because that was slowing down test execution too much, resulting in failure due to timeouts. This time, we configured SQLite's pragmas to reduce the overhead of file-based persistence.