Skip to content

Conversation

@THardy98
Copy link
Contributor

What was changed

DWISOTT

Why?

These tests having been failing most CI runs.

  1. How was this tested:
    Ran the same tests locally.

  2. Any docs updates needed?
    No

@THardy98 THardy98 requested a review from a team as a code owner October 24, 2025 01:51
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just confirming that the deflake strategy is moving the logic into the activity instead of altering the activity from the outside?

@THardy98
Copy link
Contributor Author

LGTM

Just confirming that the deflake strategy is moving the logic into the activity instead of altering the activity from the outside?

Exactly - removes a lot of checking/polling of the activity's state from the outside, which can fail/are flaky

@THardy98
Copy link
Contributor Author

Going to merge - the test failure/cancellation is unrelated (runs a sample)

@THardy98 THardy98 merged commit 4c84fc8 into main Oct 24, 2025
119 of 127 checks passed
@THardy98 THardy98 deleted the deflake-activity-operator-tests branch October 24, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants