Skip to content

Commit 15aa23b

Browse files
carlydfjlegrone
andauthored
Add test cases and arbitrary test case setup function (#127)
<!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed Add arbitrary test case setup function to set up non-standard test cases with environments that are not represented in `TemporalWorkerDeploymentStatus`. Add test cases: - manual rollout -> deploy inactive worker but no routing config changes - first progressive rollout -> target immediately becomes current - nth progressive rollout -> progressive rollout steps are respected - test that controller scales down deployments for inactive versions of failed target ## Why? We want coverage of these scenarios want to build out our ability to add more scenarios ## Checklist <!--- add/delete as needed ---> 1. Closes #33 2. How was this tested: This PR adds tests The manual mode test and the scaling down inactive versions test needed Controller code changes to pass, so I saw them fail, thereby ensuring that the test actually tests what I say it does. 3. Any docs updates needed? TODO: Possibly mention this in definition of Inactive version status, actually. Or in description of Worker Controller Scaling Behavior --------- Co-authored-by: Jacob LeGrone <[email protected]>
1 parent 6bbcb98 commit 15aa23b

File tree

16 files changed

+1254
-232
lines changed

16 files changed

+1254
-232
lines changed

go.mod

Lines changed: 105 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
module github.com/temporalio/temporal-worker-controller
22

3-
go 1.24.0
3+
go 1.24.5
44

5-
toolchain go1.24.3
5+
toolchain go1.24.6
66

77
require (
88
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
@@ -13,7 +13,7 @@ require (
1313
github.com/onsi/gomega v1.36.1
1414
github.com/pborman/uuid v1.2.1
1515
github.com/stretchr/testify v1.10.0
16-
go.temporal.io/api v1.50.0
16+
go.temporal.io/api v1.50.1
1717
go.temporal.io/sdk v1.35.0
1818
k8s.io/api v0.33.2
1919
k8s.io/apimachinery v0.33.2
@@ -22,51 +22,143 @@ require (
2222
)
2323

2424
require (
25+
cel.dev/expr v0.20.0 // indirect
26+
cloud.google.com/go v0.118.3 // indirect
27+
cloud.google.com/go/auth v0.15.0 // indirect
28+
cloud.google.com/go/auth/oauth2adapt v0.2.7 // indirect
29+
cloud.google.com/go/compute/metadata v0.6.0 // indirect
30+
cloud.google.com/go/iam v1.4.2 // indirect
31+
cloud.google.com/go/monitoring v1.24.1 // indirect
32+
cloud.google.com/go/storage v1.51.0 // indirect
33+
dario.cat/mergo v1.0.1 // indirect
34+
filippo.io/edwards25519 v1.1.0 // indirect
35+
github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.27.0 // indirect
36+
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric v0.51.0 // indirect
37+
github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.51.0 // indirect
38+
github.com/Masterminds/goutils v1.1.1 // indirect
39+
github.com/Masterminds/semver/v3 v3.3.0 // indirect
40+
github.com/Masterminds/sprig/v3 v3.3.0 // indirect
41+
github.com/apache/thrift v0.21.0 // indirect
42+
github.com/aws/aws-sdk-go v1.55.6 // indirect
43+
github.com/benbjohnson/clock v1.3.5 // indirect
2544
github.com/beorn7/perks v1.0.1 // indirect
2645
github.com/blang/semver/v4 v4.0.0 // indirect
46+
github.com/cactus/go-statsd-client/statsd v0.0.0-20200423205355-cb0885a1018c // indirect
47+
github.com/cactus/go-statsd-client/v5 v5.1.0 // indirect
48+
github.com/cenkalti/backoff/v4 v4.3.0 // indirect
2749
github.com/cespare/xxhash/v2 v2.3.0 // indirect
50+
github.com/cncf/xds/go v0.0.0-20250121191232-2f005788dc42 // indirect
51+
github.com/dgryski/go-farm v0.0.0-20240924180020-3414d57e47da // indirect
52+
github.com/dustin/go-humanize v1.0.1 // indirect
2853
github.com/emicklei/go-restful/v3 v3.11.0 // indirect
54+
github.com/emirpasic/gods v1.18.1 // indirect
55+
github.com/envoyproxy/go-control-plane/envoy v1.32.4 // indirect
56+
github.com/envoyproxy/protoc-gen-validate v1.2.1 // indirect
2957
github.com/evanphx/json-patch v5.6.0+incompatible // indirect
3058
github.com/evanphx/json-patch/v5 v5.9.11 // indirect
3159
github.com/facebookgo/clock v0.0.0-20150410010913-600d898af40a // indirect
60+
github.com/felixge/httpsnoop v1.0.4 // indirect
3261
github.com/fsnotify/fsnotify v1.7.0 // indirect
3362
github.com/fxamacker/cbor/v2 v2.7.0 // indirect
63+
github.com/go-jose/go-jose/v4 v4.0.5 // indirect
64+
github.com/go-logr/stdr v1.2.2 // indirect
3465
github.com/go-logr/zapr v1.3.0 // indirect
3566
github.com/go-openapi/jsonpointer v0.21.0 // indirect
3667
github.com/go-openapi/jsonreference v0.20.2 // indirect
3768
github.com/go-openapi/swag v0.23.0 // indirect
69+
github.com/go-sql-driver/mysql v1.9.0 // indirect
3870
github.com/go-task/slim-sprig/v3 v3.0.0 // indirect
71+
github.com/gocql/gocql v1.7.0 // indirect
3972
github.com/gogo/protobuf v1.3.2 // indirect
73+
github.com/golang-jwt/jwt/v4 v4.5.2 // indirect
4074
github.com/golang/mock v1.6.0 // indirect
75+
github.com/golang/snappy v0.0.4 // indirect
4176
github.com/google/btree v1.1.3 // indirect
4277
github.com/google/gnostic-models v0.6.9 // indirect
4378
github.com/google/go-cmp v0.7.0 // indirect
4479
github.com/google/pprof v0.0.0-20250208200701-d0013a598941 // indirect
80+
github.com/google/s2a-go v0.1.9 // indirect
4581
github.com/google/uuid v1.6.0 // indirect
82+
github.com/googleapis/enterprise-certificate-proxy v0.3.5 // indirect
83+
github.com/googleapis/gax-go/v2 v2.14.1 // indirect
84+
github.com/gorilla/mux v1.8.1 // indirect
4685
github.com/grpc-ecosystem/go-grpc-middleware v1.4.0 // indirect
4786
github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.1 // indirect
87+
github.com/hailocab/go-hostpool v0.0.0-20160125115350-e80d13ce29ed // indirect
88+
github.com/hashicorp/golang-lru/v2 v2.0.7 // indirect
89+
github.com/huandu/xstrings v1.5.0 // indirect
90+
github.com/iancoleman/strcase v0.3.0 // indirect
91+
github.com/jackc/pgpassfile v1.0.0 // indirect
92+
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 // indirect
93+
github.com/jackc/pgx/v5 v5.7.2 // indirect
94+
github.com/jackc/puddle/v2 v2.2.2 // indirect
95+
github.com/jmespath/go-jmespath v0.4.0 // indirect
96+
github.com/jmoiron/sqlx v1.4.0 // indirect
4897
github.com/josharian/intern v1.0.0 // indirect
4998
github.com/json-iterator/go v1.1.12 // indirect
99+
github.com/lib/pq v1.10.9 // indirect
50100
github.com/mailru/easyjson v0.9.0 // indirect
51101
github.com/mattn/go-colorable v0.1.14 // indirect
52102
github.com/mattn/go-isatty v0.0.20 // indirect
103+
github.com/mitchellh/copystructure v1.2.0 // indirect
104+
github.com/mitchellh/mapstructure v1.5.0 // indirect
105+
github.com/mitchellh/reflectwalk v1.0.2 // indirect
53106
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
54107
github.com/modern-go/reflect2 v1.0.2 // indirect
55108
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
109+
github.com/ncruces/go-strftime v0.1.9 // indirect
56110
github.com/nexus-rpc/sdk-go v0.3.0 // indirect
111+
github.com/olivere/elastic/v7 v7.0.32 // indirect
57112
github.com/opencontainers/go-digest v1.0.0 // indirect
113+
github.com/opentracing/opentracing-go v1.2.0 // indirect
58114
github.com/pkg/errors v0.9.1 // indirect
115+
github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10 // indirect
59116
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
60117
github.com/prometheus/client_golang v1.22.0 // indirect
61118
github.com/prometheus/client_model v0.6.1 // indirect
62119
github.com/prometheus/common v0.62.0 // indirect
63120
github.com/prometheus/procfs v0.15.1 // indirect
121+
github.com/rcrowley/go-metrics v0.0.0-20201227073835-cf1acfcdf475 // indirect
122+
github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect
64123
github.com/robfig/cron v1.2.0 // indirect
124+
github.com/robfig/cron/v3 v3.0.1 // indirect
125+
github.com/shopspring/decimal v1.4.0 // indirect
126+
github.com/sirupsen/logrus v1.9.3 // indirect
127+
github.com/sony/gobreaker v1.0.0 // indirect
128+
github.com/spf13/cast v1.7.0 // indirect
65129
github.com/spf13/pflag v1.0.5 // indirect
66130
github.com/stretchr/objx v0.5.2 // indirect
131+
github.com/temporalio/ringpop-go v0.0.0-20250130211428-b97329e994f7 // indirect
132+
github.com/temporalio/sqlparser v0.0.0-20231115171017-f4060bcfa6cb // indirect
133+
github.com/temporalio/tchannel-go v1.22.1-0.20240528171429-1db37fdea938 // indirect
134+
github.com/twmb/murmur3 v1.1.8 // indirect
135+
github.com/uber-common/bark v1.3.0 // indirect
136+
github.com/uber-go/tally/v4 v4.1.17 // indirect
67137
github.com/x448/float16 v0.8.4 // indirect
138+
go.opentelemetry.io/auto/sdk v1.1.0 // indirect
139+
go.opentelemetry.io/contrib/detectors/gcp v1.34.0 // indirect
140+
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.59.0 // indirect
141+
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.59.0 // indirect
142+
go.opentelemetry.io/otel v1.34.0 // indirect
143+
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.34.0 // indirect
144+
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.34.0 // indirect
145+
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.34.0 // indirect
146+
go.opentelemetry.io/otel/exporters/prometheus v0.56.0 // indirect
147+
go.opentelemetry.io/otel/metric v1.34.0 // indirect
148+
go.opentelemetry.io/otel/sdk v1.34.0 // indirect
149+
go.opentelemetry.io/otel/sdk/metric v1.34.0 // indirect
150+
go.opentelemetry.io/otel/trace v1.34.0 // indirect
151+
go.opentelemetry.io/proto/otlp v1.5.0 // indirect
152+
go.temporal.io/server v1.28.1 // indirect
153+
go.temporal.io/version v0.3.0 // indirect
154+
go.uber.org/atomic v1.11.0 // indirect
155+
go.uber.org/dig v1.18.0 // indirect
156+
go.uber.org/fx v1.23.0 // indirect
157+
go.uber.org/mock v0.5.0 // indirect
68158
go.uber.org/multierr v1.11.0 // indirect
69159
go.uber.org/zap v1.27.0 // indirect
160+
golang.org/x/crypto v0.37.0 // indirect
161+
golang.org/x/exp v0.0.0-20250218142911-aa4b98e5adaa // indirect
70162
golang.org/x/net v0.39.0 // indirect
71163
golang.org/x/oauth2 v0.28.0 // indirect
72164
golang.org/x/sync v0.13.0 // indirect
@@ -76,17 +168,27 @@ require (
76168
golang.org/x/time v0.10.0 // indirect
77169
golang.org/x/tools v0.30.0 // indirect
78170
gomodules.xyz/jsonpatch/v2 v2.4.0 // indirect
171+
google.golang.org/api v0.224.0 // indirect
172+
google.golang.org/genproto v0.0.0-20250303144028-a0af3efb3deb // indirect
79173
google.golang.org/genproto/googleapis/api v0.0.0-20250303144028-a0af3efb3deb // indirect
80174
google.golang.org/genproto/googleapis/rpc v0.0.0-20250303144028-a0af3efb3deb // indirect
81175
google.golang.org/grpc v1.71.0 // indirect
82176
google.golang.org/protobuf v1.36.5 // indirect
83177
gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
84178
gopkg.in/inf.v0 v0.9.1 // indirect
179+
gopkg.in/validator.v2 v2.0.1 // indirect
85180
gopkg.in/yaml.v3 v3.0.1 // indirect
86181
k8s.io/apiextensions-apiserver v0.33.0 // indirect
87182
k8s.io/klog/v2 v2.130.1 // indirect
88183
k8s.io/kube-openapi v0.0.0-20250318190949-c8a335a9a2ff // indirect
89184
k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738 // indirect
185+
modernc.org/gc/v3 v3.0.0-20250121204235-2db1fde51ea4 // indirect
186+
modernc.org/libc v1.55.3 // indirect
187+
modernc.org/mathutil v1.7.1 // indirect
188+
modernc.org/memory v1.8.2 // indirect
189+
modernc.org/sqlite v1.34.1 // indirect
190+
modernc.org/strutil v1.2.1 // indirect
191+
modernc.org/token v1.1.0 // indirect
90192
sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect
91193
sigs.k8s.io/randfill v1.0.0 // indirect
92194
sigs.k8s.io/structured-merge-diff/v4 v4.6.0 // indirect

0 commit comments

Comments
 (0)