Skip to content

Commit 3c09ca5

Browse files
committed
address more comments
1 parent 6bb6cae commit 3c09ca5

File tree

1 file changed

+5
-24
lines changed

1 file changed

+5
-24
lines changed

docs/migration-to-unversioned.md

Lines changed: 5 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Migrating from Versioned to Unversioned Workflows
22

3-
This guide walks you through reverting from versioned workflows back to unversioned Temporal Workflows. It assumes you have enabled worker versioning and currently have (or previously had) versioned workers polling the Temporal Server.
3+
This guide walks you through reverting from versioned workers to unversioned workers. It assumes you have enabled worker versioning and currently have (or previously had) versioned workers polling the Temporal Server.
44

55
---
66

@@ -66,17 +66,7 @@ worker := worker.New(client, "my-task-queue", worker.Options{})
6666

6767
### Step 2: Deploy the Unversioned Worker
6868

69-
Deploy the updated worker, using a manner of your choice, so that unversioned pollers begin polling the system.
70-
71-
Confirm unversioned pollers are polling by using the CLI and running the following
72-
command:
73-
74-
```bash
75-
temporal task-queue describe --task-queue <your-task-queue> --namespace <your-namespace>
76-
```
77-
78-
Look for pollers with an `UNVERSIONED` Build ID in the output.
79-
69+
Deploy your unversioned workers, using a manner of your choice, and ensure they are polling all of the Task Queues in your Worker Deployment. This can be done by verifying their presence on the Task Queues page (https://cloud.temporal.io/namespaces/<your-namespace>/task-queues/<your-task-queue>)
8070

8171
### Step 3: Set Current Version to Unversioned
8272

@@ -97,13 +87,13 @@ After completing the migration steps:
9787
1. **Verify in the Temporal UI** that traffic is gradually shifting from versioned workers to unversioned workers.
9888
2. **AutoUpgrade workflows** will eventually move onto the unversioned worker(s).
9989
3. **Pinned workflows** that were started on versioned workers will continue and complete execution on those pinned workers.
100-
4. **New executions** of workflows, regardless of them being *Pinned* or *AutoUpgrade*, shall start on the deployed unversioned workers (unless they have a versioning-override set.)
90+
4. **New executions** of workflows, regardless of them being *Pinned* or *AutoUpgrade*, will start on the deployed unversioned workers (unless they have a versioning-override set.)
10191

10292
---
10393

10494
## Cleanup and Garbage Collection
10595

106-
This section highlights the ways in which one can delete the corresponding Worker Versions or Worker Deployment resources that were created in Temporal.
96+
**NOTE**: The cleanup steps below are optional as it is not required to garbage collect the Worker Versions or Worker Deployment resources from the Temporal Server while migrating to unversioned workers.
10797

10898
### Deleting Kubernetes Deployments created with the Worker-Controller:
10999

@@ -112,23 +102,14 @@ The Worker Controller will delete Kubernetes Deployments, which represent versio
112102
### Deleting Worker Versions
113103

114104
A Worker Version can be deleted once it has been drained and has no active pollers.
115-
Once it's drained and without active pollers, delete the Worker Version using:
105+
Once it's drained and is without active pollers, delete the Worker Version using:
116106

117107
```bash
118108
temporal worker deployment delete-version \
119109
--deployment-name <your-deployment-name> \
120110
--build-id <your-build-id>
121111
```
122112

123-
> **Tip:** To skip the draining requirement, add the `--skip-drainage` flag:
124-
>
125-
> ```bash
126-
> temporal worker deployment delete-version \
127-
> --deployment-name <your-deployment-name> \
128-
> --build-id <your-build-id> \
129-
> --skip-drainage
130-
> ```
131-
132113
### Deleting the Worker Deployment
133114

134115
To delete a Worker Deployment:

0 commit comments

Comments
 (0)