revert the stamp > 0 check

yiminc · yiminc · commit 65cff5fb3ddf · 2025-11-03T14:59:13.000-08:00
diff --git a/service/history/api/isactivitytaskvalid/api.go b/service/history/api/isactivitytaskvalid/api.go
@@ -57,13 +57,8 @@ func isActivityTaskValid(
 	}
 
 	ai, ok := mutableState.GetActivityInfo(scheduledEventID)
-	if !ok || ai.StartedEventId != common.EmptyEventID {
-		return false, nil
+	if ok && ai.StartedEventId == common.EmptyEventID {
+		return true, nil
 	}
-
-	if ai.GetStamp() > 0 && stamp > 0 && ai.GetStamp() != stamp {
-		return false, nil
-	}
-
-	return true, nil
+	return false, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -57,13 +57,8 @@ func isActivityTaskValid(`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`ai, ok := mutableState.GetActivityInfo(scheduledEventID)`
`60`		`- if !ok \|\| ai.StartedEventId != common.EmptyEventID {`
`61`		`- return false, nil`
	`60`	`+ if ok && ai.StartedEventId == common.EmptyEventID {`
	`61`	`+ return true, nil`
`62`	`62`	`}`
`63`		`-`
`64`		`- if ai.GetStamp() > 0 && stamp > 0 && ai.GetStamp() != stamp {`
`65`		`- return false, nil`
`66`		`- }`
`67`		`-`
`68`		`- return true, nil`
	`63`	`+ return false, nil`
`69`	`64`	`}`