Comments on executions.proto and mutable_state_impl.go

Author: simvlad

proto/internal/temporal/server/api/persistence/v1/executions.proto

@@ -292,9 +292,11 @@ message WorkflowExecutionInfo {
 
 message ExecutionStats {
     int64 history_size = 1;
-    // Total size in bytes of all external payloads referenced in the workflow history.
+    // Total size in bytes of all external payloads referenced in the entire history tree of the execution, not just the current branch.
+    // This number doesn't include payloads in buffered events.
     int64 external_payload_size = 2;
-    // Total count of external payloads referenced in the workflow history.
+    // Total count of external payloads referenced in the entire history tree of the execution, not just the current branch.
+    // This number doesn't include payloads in buffered events.
     int64 external_payload_count = 3;
 }
 

service/history/workflow/mutable_state_impl.go

@@ -6400,7 +6400,7 @@ func (ms *MutableStateImpl) AddHistorySize(size int64) {
 }
 
 func (ms *MutableStateImpl) GetExternalPayloadSize() int64 {
-	return ms.executionInfo.ExecutionStats.ExternalPayloadSize
+	return ms.executionInfo.GetExecutionStats().GetExternalPayloadSize()
 }
 
 func (ms *MutableStateImpl) AddExternalPayloadSize(size int64) {
@@ -6411,7 +6411,7 @@ func (ms *MutableStateImpl) AddExternalPayloadSize(size int64) {
 }
 
 func (ms *MutableStateImpl) GetExternalPayloadCount() int64 {
-	return ms.executionInfo.ExecutionStats.ExternalPayloadCount
+	return ms.executionInfo.GetExecutionStats().GetExternalPayloadCount()
 }
 
 func (ms *MutableStateImpl) AddExternalPayloadCount(count int64) {