Fix cr test to pass cr validation criteria (#363)

* fix cr test

* skip TestAccNamespaceWithConnectivityRuleIds

Author: alice-yin

internal/provider/connectivity_rule_datasource_test.go

@@ -101,7 +101,7 @@ provider "temporalcloud" {
 
 resource "temporalcloud_connectivity_rule" "test_private" {
   connectivity_type = "private"
-  connection_id     = "vpce-12345678"
+  connection_id     = "vpce-testconnid"
   region           = "aws-us-west-2"
 }
 
@@ -146,8 +146,8 @@ output "connectivity_rule" {
 					if !ok {
 						return fmt.Errorf("expected connection_id to be a string")
 					}
-					if outputConnectionID != "vpce-12345678" {
-						return fmt.Errorf("expected connection_id to be 'vpce-12345678', got: %s", outputConnectionID)
+					if outputConnectionID != "vpce-testconnid" {
+						return fmt.Errorf("expected connection_id to be 'vpce-testconnid', got: %s", outputConnectionID)
 					}
 
 					outputRegion, ok := outputValue["region"].(string)

internal/provider/connectivity_rule_resource_test.go

@@ -73,7 +73,7 @@ func TestAccConnectivityRuleResource_AWS_Private(t *testing.T) {
 				Config: testAccConnectivityRuleResourceConfig_Private(),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					resource.TestCheckResourceAttr("temporalcloud_connectivity_rule.test_aws_private", "connectivity_type", "private"),
-					resource.TestCheckResourceAttr("temporalcloud_connectivity_rule.test_aws_private", "connection_id", "vpce-12345678"),
+					resource.TestCheckResourceAttr("temporalcloud_connectivity_rule.test_aws_private", "connection_id", "vpce-testconnid"),
 					resource.TestCheckResourceAttr("temporalcloud_connectivity_rule.test_aws_private", "region", "aws-us-west-2"),
 				),
 			},
@@ -146,7 +146,7 @@ provider "temporalcloud" {
 
 resource "temporalcloud_connectivity_rule" "test_aws_private" {
   connectivity_type = "private"
-  connection_id     = "vpce-12345678"
+  connection_id     = "vpce-testconnid"
   region           = "aws-us-west-2"
 }
 `
@@ -186,7 +186,7 @@ provider "temporalcloud" {
 
 resource "temporalcloud_connectivity_rule" "test" {
   connectivity_type = "private"
-  connection_id     = "vpce-12345678"
+  connection_id     = "vpce-testconnid"
 }
 `
 }
@@ -199,7 +199,7 @@ provider "temporalcloud" {
 
 resource "temporalcloud_connectivity_rule" "test" {
   connectivity_type = "private"
-  connection_id     = "vpce-12345678"
+  connection_id     = "vpce-testconnid"
   region           = "gcp-us-central1"
 }
 `