Revert "delete handler/test for ns custom search attribute (#328)" (#355)

This reverts commit 9d23d0f.

Author: gregmankes

internal/provider/namespace_search_attribute_resource.go

@@ -295,48 +295,10 @@ func (r *namespaceSearchAttributeResource) Update(ctx context.Context, req resou
 }
 
 func (r *namespaceSearchAttributeResource) Delete(ctx context.Context, req resource.DeleteRequest, resp *resource.DeleteResponse) {
-	var state namespaceSearchAttributeModel
-	resp.Diagnostics.Append(req.State.Get(ctx, &state)...)
-	if resp.Diagnostics.HasError() {
-		return
-	}
-
-	withNamespaceLock(state.NamespaceID.ValueString(), func() {
-		ns, err := r.client.CloudService().GetNamespace(ctx, &cloudservicev1.GetNamespaceRequest{
-			Namespace: state.NamespaceID.ValueString(),
-		})
-		if err != nil {
-			resp.Diagnostics.AddError("Failed to get namespace", err.Error())
-			return
-		}
-
-		spec := ns.GetNamespace().GetSpec()
-		_, ok := spec.GetSearchAttributes()[state.Name.ValueString()]
-		if !ok {
-			// search attribute is already deleted
-			resp.Diagnostics.AddWarning("Custom search attribute was already deleted", state.ID.String())
-			return
-		}
-
-		// delete the search attribute
-		delete(spec.SearchAttributes, state.Name.ValueString())
-
-		svcResp, err := r.client.CloudService().UpdateNamespace(ctx, &cloudservicev1.UpdateNamespaceRequest{
-			Namespace:        state.NamespaceID.ValueString(),
-			Spec:             spec,
-			ResourceVersion:  ns.GetNamespace().GetResourceVersion(),
-			AsyncOperationId: uuid.New().String(),
-		})
-		if err != nil {
-			resp.Diagnostics.AddError("Failed delete search attribute", err.Error())
-			return
-		}
-
-		if err := client.AwaitAsyncOperation(ctx, r.client, svcResp.GetAsyncOperation()); err != nil {
-			resp.Diagnostics.AddError("Failed delete search attribute", err.Error())
-			return
-		}
-	})
+	resp.Diagnostics.AddWarning(
+		"Delete Ignored",
+		"The Temporal Cloud API does not support deleting a search attribute. Terraform will silently drop this resource but will not delete it from the Temporal Cloud namespace.",
+	)
 }
 
 func (r *namespaceSearchAttributeResource) ImportState(ctx context.Context, req resource.ImportStateRequest, resp *resource.ImportStateResponse) {

internal/provider/namespace_search_attribute_resource_test.go

@@ -208,59 +208,3 @@ resource "temporalcloud_namespace_search_attribute" "custom_search_attribute" {
 		},
 	})
 }
-
-func TestAccNamespaceWithSearchAttributesDelete(t *testing.T) {
-	name := fmt.Sprintf("%s-%s", "tf-search-attributes", randomString(10))
-	config := func(name string, includeSearchAttribute bool) string {
-		base := fmt.Sprintf(`
-provider "temporalcloud" {
-
-}
-
-resource "temporalcloud_namespace" "terraform" {
-  name               = "%s"
-  regions            = ["aws-us-east-1"]
-  retention_days     = 14
-  accepted_client_ca = base64encode(<<PEM
------BEGIN CERTIFICATE-----
-MIIBxjCCAU2gAwIBAgIRAlyZ5KUmunPLeFAupDwGL8AwCgYIKoZIzj0EAwMwEjEQ
-MA4GA1UEChMHdGVzdGluZzAeFw0yNDA4MTMyMzQ2NThaFw0yNTA4MTMyMzQ3NTha
-MBIxEDAOBgNVBAoTB3Rlc3RpbmcwdjAQBgcqhkjOPQIBBgUrgQQAIgNiAARG+EuL
-uKRsNWs7Rbz6ciaJQB7QINTRLmTgGGE8H/wAs+KjvctjPdDdqFPZrxShRY3PUdk2
-pgQKRugMTe3N52pxBx4Iablz8felfdv4kyLQbdsJzY9XmCYX3D68/9Hxsl2jZzBl
-MA4GA1UdDwEB/wQEAwIBhjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSYC5/u
-K78bK1M8Fv1M6ELMjF2ZMDAjBgNVHREEHDAaghhjbGllbnQucm9vdC50ZXN0aW5n
-LjBycDUwCgYIKoZIzj0EAwMDZwAwZAIwSycjxxmYTgV5eSJbaGMINr5LQgyKQUHQ
-ryBKSGLKASa/e2ntyhsqRhj77gJ8DmkZAjAIlpDacF+Sq1kpZ5tMV7ZLElcujzj4
-US8pEmNuIiCguEGwi+pb5CWfabETEHApxmo=
------END CERTIFICATE-----
-PEM
-)
-}`, name)
-
-		if includeSearchAttribute {
-			return fmt.Sprintf(`%s
-
-resource "temporalcloud_namespace_search_attribute" "custom_search_attribute" {
-  namespace_id = temporalcloud_namespace.terraform.id
-  name         = "CustomSearchAttribute"
-  type         = "text"
-}`, base)
-		}
-
-		return base
-	}
-
-	resource.ParallelTest(t, resource.TestCase{
-		PreCheck:                 func() { testAccPreCheck(t) },
-		ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
-		Steps: []resource.TestStep{
-			{
-				Config: config(name, true),
-			},
-			{
-				Config: config(name, false),
-			},
-		},
-	})
-}